Repository navigation
fix: resolve statistics keys with the simulated path instead of the host path - #1162
Merged
Merged
Conversation
…ost path When simulating another operating system, the host Path produced wrong keys and fell back to the process's current directory, which made watcher tests fail on macOS whenever a real file system test had left it pointing at a deleted directory. The directory cleaner now also resets the current directory when a test moved it into a subdirectory, so it no longer leaves the process in a deleted directory.
vbreuss
force-pushed
the
fix/path-statistics-host-cwd
branch
from
October 29, 2026 22:36
63f9774 to
55edb7e
Compare
vbreuss
enabled auto-merge (squash)
October 29, 2026 22:48
|
|
This is addressed in release v7.2.0. |
This was referenced Oct 30, 2026
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When simulating another operating system, the host Path produced wrong keys and fell back to the process's current directory, which made watcher tests fail on macOS whenever a real file system test had left it pointing at a deleted directory. The directory cleaner now also resets the current directory when a test moved it into a subdirectory, so it no longer leaves the process in a deleted directory.