Repository navigation
test: run the flaky timer mock tests on dedicated threads instead of the thread pool - #1190
Merged
Merged
Conversation
…the thread pool `AdvanceBy_WhenTheCallerHoldsALockTheCallbackNeeds_ShouldNotDeadlock` and `Wait_WhenTheCallbackDisposesTheTimer_ShouldNotThrow` failed on .NET Framework on the Windows build of main, as both ran their advancing or waiting code through `Task.Run`, `Task.Delay` and asynchronous continuations, which the thread pool may run too late under parallel tests on .NET Framework. The tests now use dedicated threads and synchronous waits, like the other timer tests that hit this before.
vbreuss
enabled auto-merge (squash)
November 3, 2026 11:20
|
|
This is addressed in release v8.0.0. |
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdvanceBy_WhenTheCallerHoldsALockTheCallbackNeeds_ShouldNotDeadlockandWait_WhenTheCallbackDisposesTheTimer_ShouldNotThrowfailed on .NET Framework on the Windows build of main, as both ran their advancing or waiting code throughTask.Run,Task.Delayand asynchronous continuations, which the thread pool may run too late under parallel tests on .NET Framework. The tests now use dedicated threads and synchronous waits, like the other timer tests that hit this before.