Skip to content

STUN: stop spamming if a keepalive request cant be sent #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ibn-Butt-Toota wants to merge 1 commit into
base: master
Choose a base branch
from
Open

STUN: stop spamming if a keepalive request cant be sent #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/steamnetworkingsockets/clientlib/steamnetworkingsockets_ice_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2339,6 +2339,18 @@ void CSteamNetworkingICESession::STUNRequestCallback_ServerReflexiveKeepAlive( c

const int nSTUNServerIdx = std::max( 0, index_of( m_vecSTUNServers, info.m_pRequest->m_remoteAddr ) );
const int nNextSTUNServerIdx = ( nSTUNServerIdx + 1 ) % len( m_vecSTUNServers );

// If the request failed because the packet could not be sent at all (airplane mode
// or connection drops for whatever reason), requeuing right away would spam STUN requests:
// each new request fails immediately and queues another request, causing the service thread
// to never sleep. Instead, we can save the server to try next and leave the attempt to the
// regular keepalive timer.
if ( info.m_pRequest->m_usecLastSentTime == 0 )
{
pIntf->m_addrSTUNServer = m_vecSTUNServers[ nNextSTUNServerIdx ];
return;
}

pIntf->QueueBindRequest( m_vecSTUNServers[ nNextSTUNServerIdx ], &CSteamNetworkingICESession::STUNRequestCallback_ServerReflexiveKeepAlive, m_nEncoding );
}

Expand Down