Repository navigation
[TF2] Expands elegability and removes some jank for quick-fix mirroring - #2178
Open
CrazyAmphibian wants to merge 1 commit into
Open
CrazyAmphibian wants to merge 1 commit into
CrazyAmphibian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick-fix mirroring has some strange quirks with it, namely that
This tries to make the quick-fix a bit more intuitive in how it chooses to mirror by doing the following:
The following things will now be mirrored by the quick-fix:
The following things are NOT mirrored:
This makes changes to
CTFPlayer::OnTakeDamage, addingbQuickFixCanMirrorKnockbackandbQuickFixMirrorRequireAirborne, and removing thebIsPyroDetonateJumpingcheck as it is now unused. additionally modifiesCTFPlayer::OnTakeDamage_Aliveto bypass knockback immunity on self-damage, with an exception made for unwrangled sentries. also modifiesCTFSpellBook::CastRocketJumpto check for quick-fix medics so that it is mirroredTested on windows 10 x64, release build
Attached videos showcase the new changes.
2026-10-30.11-51-02.mp4
2026-10-30.11-29-59.mp4
2026-10-30.11-32-23.mp4
2026-10-29.23-25-59.mp4
2026-10-30.12-06-17.mp4