Skip to content

[TF2] Expands elegability and removes some jank for quick-fix mirroring - #2178

Open
CrazyAmphibian wants to merge 1 commit into
ValveSoftware:masterfrom
CrazyAmphibian:quick-fix-mirror-overhaul
Open

CrazyAmphibian wants to merge 1 commit into
ValveSoftware:masterfrom
CrazyAmphibian:quick-fix-mirror-overhaul

Conversation

@CrazyAmphibian

@CrazyAmphibian CrazyAmphibian commented Oct 30, 2026 •

Copy link
Copy Markdown

Description

Quick-fix mirroring has some strange quirks with it, namely that

  • mirroring is only done if your pocket is airborne, the medic's status is ignored. this poses a problem because you don't need to be in the air to rocket jump, demoman especially often just crouches over stickies to jump, which is ignored by this behavior. additionally, the check also prevents mirroring if the pocket is underwater when the blast jump works correctly regardless.
  • mirroring only checks for 3 classes (demo, pyro, soldier), and only checks blast damage (some weapons do not deal self blast damage). other classes have ways to deal self-damage that is not always typed as blast, either.

This tries to make the quick-fix a bit more intuitive in how it chooses to mirror by doing the following:

  • all self-damage from any class is eligible to mirror (except melee/bleed, see below for why)
  • removes the behavior that checks if the pocket is ungrounded. this check has been made optional, and only triggered by certain damage sources, and is intended to prevent accidental knockback mirroring. the check itself also now additionally applies to the medic, to put a bit more control in his hands
  • makes all (a couple exceptions) self-damage bypass knockback immunity, so that anything mirrored will not be prevented by its ubercharge.

The following things will now be mirrored by the quick-fix:

  • Short circuit alt-fire
  • Wrangled sentry rockets
  • Wrangled sentry bullets (requires being airborne)
  • Pumpkin bombs (includes reskins, and ones spawned by spells)
  • The rocket jump halloween spell (does not restore the medic's health)

The following things are NOT mirrored:

  • the boston basher. if mirrored, it causes medic to become a helicopter should the scout constantly attack and hit himself.
  • the half-zatoichi's honorbound holster penalty

This makes changes to CTFPlayer::OnTakeDamage, adding bQuickFixCanMirrorKnockback and bQuickFixMirrorRequireAirborne , and removing the bIsPyroDetonateJumping check as it is now unused. additionally modifies CTFPlayer::OnTakeDamage_Alive to bypass knockback immunity on self-damage, with an exception made for unwrangled sentries. also modifies CTFSpellBook::CastRocketJump to check for quick-fix medics so that it is mirrored

Tested on windows 10 x64, release build

Attached videos showcase the new changes.

2026-10-30.11-51-02.mp4
2026-10-30.11-29-59.mp4
2026-10-30.11-32-23.mp4
2026-10-29.23-25-59.mp4
2026-10-30.12-06-17.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant