Repository navigation
[TF2] MvM: Fix tankboss visual health bar not updating on health change via inputs - #2201
Open
HyperionCoding wants to merge 1 commit into
Open
HyperionCoding wants to merge 1 commit into
HyperionCoding wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix tankboss visual health bar not updating when the tank health or max health is changed via inputs, only when damaged normally via
OnTakeDamage. The cause is that the health bar is tracked inm_lastHealthPercentagebut the value is updated only when taking damage, not on any (max/) health change.The fix is to override
SetHealthandSetMaxHealthfunctions to also changem_lastHealthPercentage. I chose to ignore firing them_outputOnHealthBelowXXPercentoutputs because if the health is changed via inputs the outputs can be fired manually too.Current:
https://github.com/user-attachments/assets/c17282b4-1e46-4dc2-a12c-f04c7e04d60e
Fixed:
https://github.com/user-attachments/assets/822434fd-c0db-4cd6-8087-241c03f25452