Repository navigation
http: reduce raw header name allocations Reuse the values array instead of allocating a second result array. Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com> PR-URL: https://github.com/nodejs/node/pull/66488 Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Tim Perry <pimterry@gmail.com> - #1
Merged
Merged
Conversation
PR-URL: nodejs#66620 Refs: simdjson/simdjson#2913 Refs: nodejs#66495 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
env.h includes inspector_profiler.h, which included simdjson.h for the types of two virtual methods and a parser member. As a result, about 155 files in src/ parsed the amalgamated simdjson header, which is over 10 MB. Keep simdjson out of inspector_profiler.h: the profile connections now say which field of `result` holds the profile, and WriteProfile() takes the profile as raw JSON. The parser becomes a local variable, so its buffers are no longer kept alive for the lifetime of the Environment. Also drop the unused include from node_task_runner.h, and let the config file reader rewind its document instead of parsing the whole file a second time with a second parser. Now only the eight files that use simdjson include it. On an Apple M-series machine, a clean rebuild of the src/ objects takes about 15% less CPU time (376 s to 320 s) and 19% less wall time at -j14. Signed-off-by: Daniel Lemire <daniel@lemire.me> PR-URL: nodejs#66620 Refs: simdjson/simdjson#2913 Refs: nodejs#66495 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
traceCallback() defaults to a frozen context but writes the callback's result or error to it. Allocate a fresh context when undefined is passed and subscribers are present, matching traceSync() and tracePromise(). Set the prototype after allocation to avoid dictionary-mode properties. Assisted-by: pi Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: nodejs#66481 Reviewed-By: Bryan English <bryan@bryanenglish.com>
The GHA benchmark never built the addons of benchmark/napi, and its --debug-node build made benchmark/common.js look for them in build/Debug. Build them when the napi category runs, and pick the build type as test/common does. Refs: nodejs#66395 Signed-off-by: Nigro Simone <nigro.simone@gmail.com> PR-URL: nodejs#66423 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Original commit message:
fix compilation with GCC 16 on arm64
Change-Id: I2cbe5f2a68d4a69bac48eea876ff0ed0cb589171
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8500805
Reviewed-by: Joyee Cheung <joyee@igalia.com>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#110517}
Refs: v8/v8@8d14d49
PR-URL: nodejs#66627
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> PR-URL: nodejs#65750 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Signed-off-by: lazerg <lazerg2@gmail.com> Assisted-by: Claude Code PR-URL: nodejs#66565 Fixes: nodejs#66562 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Bumps the doc group in /tools/doc with 2 updates: [@doc-kit/generator-react](https://github.com/nodejs/doc-kit/tree/HEAD/packages/react) and [@node-core/doc-kit](https://github.com/nodejs/doc-kit/tree/HEAD/packages/node). Updates `@doc-kit/generator-react` from 0.4.0 to 0.4.2 - [Release notes](https://github.com/nodejs/doc-kit/releases) - [Changelog](https://github.com/nodejs/doc-kit/blob/main/packages/react/CHANGELOG.md) - [Commits](https://github.com/nodejs/doc-kit/commits/@doc-kit/generator-react@0.4.2/packages/react) Updates `@node-core/doc-kit` from 2.0.4 to 2.0.5 - [Release notes](https://github.com/nodejs/doc-kit/releases) - [Changelog](https://github.com/nodejs/doc-kit/blob/main/packages/node/CHANGELOG.md) - [Commits](https://github.com/nodejs/doc-kit/commits/@node-core/doc-kit@2.0.5/packages/node) --- updated-dependencies: - dependency-name: "@doc-kit/generator-react" dependency-version: 0.4.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: doc - dependency-name: "@node-core/doc-kit" dependency-version: 2.0.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: doc ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: nodejs#66632 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#66497 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#66626 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
AbortSignal.any() copies the source WeakRefs of a composite input into the new composite, so nested composites share them. Those WeakRefs were also used as the unregister tokens for the registrations that prune a composite's sources once they are collected. When an inner composite was collected first, its cleanup therefore also unregistered the outer composite from the same sources. An observed outer composite then stayed in gcPersistentSignals, together with its listeners, even after all of its sources were gone and nothing could abort it anymore. Use each composite's own WeakRef as the unregister token instead, so collecting one composite only removes its own registrations. Fixes: nodejs#66612 Refs: nodejs#62367 Assisted-by: Claude Code Signed-off-by: journaltraces <kxenk@protonmail.com> PR-URL: nodejs#66617 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Pulls in nodejs/node-pr-labeler#20, which counts each subsystem once before applying the four-subsystem limit that collapses labels into `lib / src`. Until now any PR touching three or more files under a two-label rule (e.g. `src/quic/`, `src/crypto/`) was collapsed even though it only touched one subsystem. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: nodejs#66606 Refs: nodejs/node-pr-labeler@dfe5eb3 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Add deps/v8/** to the QUIC workflow's pull request path filter so V8 updates trigger its build and tests. Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com> PR-URL: nodejs#66602 Refs: nodejs#66537 Refs: https://github.com/nodejs/node/actions/runs/37675498427/job/112978479932 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Tim Perry <pimterry@gmail.com>
Signed-off-by: Vas Sudanagunta <vas@commonkarma.org> PR-URL: nodejs#66563 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reuse the values array instead of allocating a second result array. Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com> PR-URL: nodejs#66488 Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Tim Perry <pimterry@gmail.com>
Owner
Author
|
No modifications made by me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.