Skip to content

feat: ACNA-3249 - node 22 has warning in every cli command (eslint error) - #124

Merged
shazron merged 1 commit into
mainfrom
story/ACNA-3249
Nov 13, 2024
Merged

shazron merged 1 commit into
mainfrom
story/ACNA-3249

Conversation

@shazron

@shazron shazron commented Nov 8, 2024 •

Copy link
Copy Markdown
Contributor

Description

see adobe/aio-cli#679

How Has This Been Tested?

  • npm i && npm test
  • manual test of this plugin while debugging (works)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov

codecov Bot commented Nov 8, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (21d0f11) to head (61f6b41).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          647       647           
  Branches       132       132           
=========================================
  Hits           647       647           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron
shazron marked this pull request as ready for review November 12, 2024 11:13
@shazron
shazron merged commit 779629f into main Nov 13, 2024
@shazron
shazron deleted the story/ACNA-3249 branch November 13, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants