Repository navigation
fix: remove node-fetch, use built-in fetch - #843
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 3223 3222 -1
Branches 632 632
=========================================
- Hits 3223 3222 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelGoberling
approved these changes
Mar 6, 2025
MichaelGoberling
left a comment
Contributor
There was a problem hiding this comment.
Awesome this is much needed
Do we need a min engine now for the built in fetch? I recall it became stable relatively recently
this was deleted in master already
purplecabbage
added a commit
that referenced
this pull request
Nov 10, 2025
* fix: remove node-fetch, use built-in fetch --------- Co-authored-by: Jesse MacFadyen <purplecabbage@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
node-fetch@v2's dependencies use the built in punycode module, which is deprecated in node-22, and prints out a deprecation warning.
How Has This Been Tested?
-npm test
Types of changes
Checklist: