Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Adjustments for theming changes in AngularJS Material 1.2.0 #46

Closed
Closed
Adjustments for theming changes in AngularJS Material 1.2.0#46
Assignees
Splaktar
Labels
P3: important
Milestone
1.0.0

Description

@Splaktar
Splaktar
opened on Jun 30, 2020

Based on angular/material#11376 (and likely some other PRs), there may need to be some adjustments to this library for it to keep working with AngularJS Material 1.2.0. This issue is to keep track of any of those issues and remember to put out a new release of this library when (or soon after) AngularJS Material 1.2.0 is released.

Activity

  1. Splaktar
    added
    P2: required
    on Jun 30, 2020
  2. Splaktar
    self-assigned this
    on Jun 30, 2020

  3. Splaktar commented on Oct 29, 2020

    @Splaktar
    Splaktar
    on Oct 29, 2020
    ContributorAuthor
    [16:27:57]: Retrieved versions from AngularJS Material docs (12x)
[16:27:59]: Successfully built 1.2.1.
[16:28:01]: Successfully built 1.1.26.
[16:28:02]: Successfully built 1.1.25.
[16:28:04]: Successfully built 1.2.0.
[16:28:06]: Successfully built 1.2.0-rc.2.
[16:28:08]: Successfully built 1.2.0-rc.1.
[16:28:09]: Successfully built 1.1.24.
[16:28:09]: Using AngularJS Material version from cache.
[16:28:10]: Successfully built 1.1.23.
[16:28:10]: Using AngularJS Material version from cache.
[16:28:10]: Successfully built 1.1.22.
[16:28:10]: Using AngularJS Material version from cache.
[16:28:10]: Successfully built 1.1.22-rc.0.
[16:28:10]: Using AngularJS Material version from cache.
[16:28:10]: Successfully built 1.1.21.
[16:28:10]: Using AngularJS Material version from cache.
[16:28:10]: Successfully built 1.1.20.
[16:28:10]: Successfully tested the tool against all supported versions.

    The 1.2.x releases seem to be working with this tool so far (at least according to the tests).

  4. Splaktar
    added
    P3: important
    and removed
    P2: required
    on Oct 29, 2020

  5. Splaktar commented on Oct 29, 2020

    @Splaktar
    Splaktar
    on Oct 29, 2020
    ContributorAuthor

    As mentioned in #44 (comment), 1.1.23 changed a couple .scss files to be Sass partials. That issue is fixed and now the minimum version supported in 1.1.23.

    However, there is another exception listed in that comment that needs to be investigated. It may related to the 1.2.x changes.

  6. Splaktar commented on Oct 30, 2020

    @Splaktar
    Splaktar
    on Oct 30, 2020
    ContributorAuthor

    722f08e fixed an issue with the original code, so it wasn't due to 1.2.0.

    I think that we're clear of 1.2.0 issues at this point with 1.0.0-rc.3. If some user testing on that goes well, we'll cut 1.0.0 and close this issue.

  7. Splaktar
    added this to the 1.0.0 milestone on Nov 3, 2020

  8. Splaktar commented on Nov 3, 2020

    @Splaktar
    Splaktar
    on Nov 3, 2020
    ContributorAuthor

    Verified in #44 (comment) that the latest RC works with a real app using AngularJS Material 1.2.x.

  9. Splaktar
    closed this as completedon Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3: important

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions