This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
menu: dark theme no more handled #10062
Description
Actual Behavior:
Hi, I just update angular-material from 1.0.8 to 1.1.1 and md-menu is no more handling dark-theme.
CodePen (or steps to reproduce the issue): *
http://codepen.io/anon/pen/KNqGpr
this codepen is the md-menu from angular-material website, configured to use dark-theme on 1.1.1
http://codepen.io/anon/pen/qqjJZZ
this one is the same one but with 1.0.9 version.
I did some test, regression occured in 1.1.0 version.
Regards,
Benoit.
Reacted by Marco Alvarado and Guillermo Lopez
Activity
ElPsyCongro commentedon Dec 23, 2016
+1
clshortfuse commentedon Dec 24, 2016
Related #9100
PR #9212
The current debate is whether to render light or dark background, if it's a regression or correction in 1.1.0
zeprone commentedon Jan 7, 2017
based on https://material.io/guidelines/style/color.html#color-themes
we should have a dark background, like the dialog one in section "dark theme"
clshortfuse commentedon Jan 27, 2017
Closing, since duplicate of #9100