Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

calendar: demo broken, showing 1880 dates, while model is correct #11919

Closed
#11939
Closed
calendar: demo broken, showing 1880 dates, while model is correct#11919
#11939
Assignees
Splaktar
Labels
P1: urgentUrgent issues that should be addressed in the next minor or patch release.has: Pull RequestA PR has been created to address this issueseverity: regressionThis issue is related to a regressiontype: bug
Milestone
1.1.23

Description

@Splaktar
Splaktar
opened on May 27, 2020

Bug

Demo and steps to reproduce the issue

This blank StackBlitz demo can be used to create a reproduction that demonstrates your issue.

Demo URL (required)*: https://material.angularjs.org/HEAD/demo/datepicker

Detailed Reproduction Steps

  1. Just load the page of the datepicker demos
  2. Look at the calendar

Explain the expected behavior

It should show the start date as today and the end date as 5 days from today. The model values are correct.

Explain the current behavior

The start date appears to be Jan 1880 and the end date appears to be sometime in May 1880. The model values appear to be correct. But the calendar hasn't scrolled to the right month/year.

Discuss the use-case or motivation for changing the existing behavior

Basic functionality.

List the affected versions of AngularJS, Material, OS, and browsers

  • AngularJS: 1.1.23-master
  • AngularJS Material: 1.7.9
  • OS: macOS Catalina
  • Browsers: Chrome 83

Add anything else we should know

Screenshots

Screen Shot 2020-05-27 at 03 38 28

Activity

  1. Splaktar
    added
    type: bug
    needs: investigationThe cause of this issue is not well understood and needs to be investigated by the team or community
    severity: regressionThis issue is related to a regression
    P1: urgentUrgent issues that should be addressed in the next minor or patch release.
    on May 27, 2020
  2. Splaktar
    added this to the 1.1.23 milestone on May 27, 2020
  3. Splaktar
    self-assigned this
    on May 27, 2020
  4. Splaktar
    changed the title [-]calendar: demo broken, showing 1880 dates[/-] [+]calendar: demo broken, showing 1880 dates, while model is correct[/+] on May 27, 2020

  5. Splaktar commented on Jun 15, 2020

    @Splaktar
    Splaktar
    on Jun 15, 2020
    ContributorAuthor

    The commit that caused this was 2a01746 from PR #11906.

  6. Splaktar commented on Jun 16, 2020

    @Splaktar
    Splaktar
    on Jun 16, 2020
    ContributorAuthor

    It turns out that this comment was inaccurate. #8585 was found to not be a real issue and was closed w/o any changes. So this is still needed for md-calendar and needs to be marked as part of the design and no longer a workaround of a md-virtual-repeat-container bug.

  7. Splaktar
    added
    has: Pull RequestA PR has been created to address this issue
    and removed
    needs: investigationThe cause of this issue is not well understood and needs to be investigated by the team or community
    on Jun 16, 2020
  8. Splaktar
    added a commit that references this issue on Jun 16, 2020

    fix(calendar): revert removal of workaround for virtual repeat issue

    ec26938
  9. Splaktar
    closed this as completedin #11939on Jun 17, 2020
  10. Splaktar
    added a commit that references this issue on Jun 17, 2020

    fix(calendar): revert removal of workaround for virtual repeat issue

    6f64da6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1: urgentUrgent issues that should be addressed in the next minor or patch release.has: Pull RequestA PR has been created to address this issueseverity: regressionThis issue is related to a regressiontype: bug

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions