Skip to content

[Java] Checker Framework annotations for AutoCloseables in arrow-memory-core are incorrect #130

New issue
New issue
Closed
#1017
Closed
[Java] Checker Framework annotations for AutoCloseables in arrow-memory-core are incorrect#130
#1017
Assignees
davisusanibar
Labels
good first issueGood for newcomers
Milestone
19.0.0

Description

@lidavidm
lidavidm
opened on Jan 26, 2024

Describe the enhancement requested

AutoCloseables.close works with nulls and collections of nulls, but isn't annotated appropriately, making downstream usage harder.

Component(s)

Java

Activity

  1. davisusanibar commented on Jan 26, 2024

    @davisusanibar
    davisusanibar
    on Jan 26, 2024
    Contributor

    take

  2. github-actions
    assigned
    davisusanibar
    on Jan 26, 2024

  3. davisusanibar commented on Jan 29, 2024

    @davisusanibar
    davisusanibar
    on Jan 29, 2024
    Contributor

    In particular, this is due to the fact that the class org/apache/arrow/util/AutoCloseables.java is not referenced inside the memory core, which means that nullables cannot be de-referenced in those close methods.

  4. davisusanibar commented on Jan 29, 2024

    @davisusanibar
    davisusanibar
    on Jan 29, 2024
    Contributor

    Let me add that manually.

  5. lidavidm commented on Jan 29, 2024

    @lidavidm
    lidavidm
    on Jan 29, 2024
    MemberAuthor

    Yes, I think you will run into this as you enable the checker in other modules.

  6. lidavidm commented on Jan 29, 2024

    @lidavidm
    lidavidm
    on Jan 29, 2024
    MemberAuthor

    Also, see apache/arrow-adbc#1495 where I have added type stubs to override annotations in some Arrow Java libraries.

  7. assignUser
    transferred this issue fromapache/arrowon Nov 26, 2024
  8. lidavidm
    added
    good first issueGood for newcomers
    on Jan 10, 2025
  9. axreldable
    added a commit that references this issue on Feb 12, 2026

    apacheGH-130: Fix AutoCloseables to work with @nullable structures

    338980c
  10. github-actions
    added this to the 19.0.0 milestone on Feb 13, 2026
  11. axreldable
    added a commit that references this issue on Feb 16, 2026

    apacheGH-130: Fix AutoCloseables to work with @nullable structures

    d5c317c
  12. jbonofre
    added a commit that references this issue on Feb 17, 2026

    GH-130: Fix AutoCloseables to work with @nullable structures (#1017)

    3298443
  13. jbonofre
    closed this as completedin #1017on Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

good first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions