[rnewson]

Overview

Testing recommendations

Related Issues or Pull Requests

Checklist

• This is my own work, I did not use AI, LLM's or similar technology
• Code is written and works correctly
• Changes are covered by tests
• Any new configurable parameters are documented in rel/overlay/etc/default.ini
• Documentation changes were made in the src/docs folder
• Documentation changes were backported (separated PR) to affected branches

[nickva]

Since we're removing the hack we should bubble up the "invalid replication" exceptions better to the users as 4xx errors and not 500s:

So maybe we add a few clauses to error_info:

error_info({error, local_endpoints_not_supported}) ->
    {400, ~"invalid_replication", ~"local database names are not supported, use a full URL"};
error_info({error, ~"Missing replicator database" = Reason}) ->
    {400, ~"invalid_replication", Reason};

To avoid the odd binary as reason we could change that as well (it's in couch_replicator_parse):

throw({error, <<"Missing replicator database">>}) -> throw({error, missing_replicator_database}) ?