Repository navigation
MsSql: Stop reading statement keywords such as SET as implicit aliases - #2991
Open
colinhacks wants to merge 4 commits into
Open
colinhacks wants to merge 4 commits into
colinhacks wants to merge 4 commits into
Conversation
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialects: MsSql
With
require_semicolon_stmt_delimiter = false,SELECT 1followed bySET @x = 1on the next line failed withExpected: an SQL statement, found: @x, becauseSETwas read as an implicit alias of1.BEGIN,OPEN,CLOSE,DEALLOCATE,GRANT,DENY,WAITFORandKILLfailed the same way after a select item, most of them after a table name too, andCOMMIT,ROLLBACKandREVOKEwere misread with no error:SELECT a FROM tfollowed byCOMMITcame back as one statement,SELECT a FROM t COMMIT.All of these are reserved keywords in T-SQL (https://learn.microsoft.com/en-us/sql/t-sql/language-elements/reserved-keywords-transact-sql), so they join the statement keywords MsSql already keeps out of aliases.
USEis reserved too but stays out, sinceparse_select_table_with_index_hintsexpectsSELECT * FROM T USE LIMIT 1to read it as an alias in every dialect without table hints.Written with an AI coding assistant.