Repository navigation
test(visualMap): cover vertical handle label overlap - #21808
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Adds a focused visual regression case for vertical continuous visualMap handle-label overlap.
Fixed issues
Details
Before: What was the problem?
The overlap fix covers the reported behavior, but the visual regression suite has no focused vertical case for handles that are very close or coincident.
After: How does it behave after the fixing?
A standalone synthetic-data fixture renders
[49, 51]and[50, 50]ranges and is included in the primary visual-case list. The fixture contains no real-world or customer data.Document Info
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/visualMap-handle-label-overlap.htmlMerging options
Other information
Checks run: JavaScript syntax checks for the new inline script and
test/-cases.js, plusgit diff --check. A synthetic SSR positive control against the checked-indist/echarts.js6.1.0 reproduced 8 px overlap for[49, 51]and 12 px for[50, 50]; that is the released bundle, not a build of current TypeScript source. The current-source build and Puppeteer visual suite were not run. The repository's CONTRIBUTING.md and PR template specify no mandatory test command for this test-only change; no current-source browser result is claimed. No CI was queried.