Repository navigation
fix(label): finish the label fade-in before an instant update - #21810
Open
MindFreeze wants to merge 1 commit into
Open
MindFreeze wants to merge 1 commit into
MindFreeze wants to merge 1 commit into
Conversation
Roam actions update the label layout without animation. The instant branch of updateProps stops every animation of the label, so a fade-in that was still running stayed at its current opacity for good.
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Finish a running label fade-in before an instant label update, so zooming during the fade no longer leaves labels half transparent.
Fixed issues
N.A.
Details
Before: What was the problem?
When labels are laid out for the first time with animation enabled,
LabelManagerfades them in from opacity 0. A zoom roam callsapi.updateLabelLayout(), and roam payloads disable animation, soupdatePropson the label takes the instant branch ofanimateOrSetProps. That branch callsel.stopAnimation(), which also stops the fade-in. The label keeps the opacity it had reached, and later layouts never touch its opacity again.Graph with
layout: 'none', zoomed 1 second into a 5 second fade-in. The labels stay at opacity 0.2:After: How does it behave after the fixing?
Before an instant update,
_animateLabelsfinishes the label's ownenteranimations withstopAnimation('enter', true). The label jumps to its final opacity. Animated updates are unchanged.Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
test/label-animation.html, last case.Others
Merging options
Other information
Found in the Home Assistant network graph, which carries this fix as a patch: home-assistant/frontend#55397.