Skip to content

Stabilize pipe and table authentication tests - #19315

Open
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:codex/fix-master-it-flakes-pr
Open

Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:codex/fix-master-it-flakes-pr

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Summary

  • Make sink shutdown assertions deterministic by waiting for connector close to enter its blocked state before checking bounded external-sink return and built-in-sink waiting behavior.
  • Retry table-model pipe leader-stop replication only for recognized transient RPC failures, including nested causes and chained SQL exceptions; fail fast on Awaitility timeouts and unrelated failures.
  • Wait for granted table access to become visible before authorization assertions, retrying only the expected NO_PERMISSION response for the target database.
  • Flush the verified receiver baseline before the tree-model lifecycle test restarts the receiver.

Example

After GRANT SELECT to a user, USE test2 can briefly return NO_PERMISSION while authorization propagates. The test now retries only that expected response for up to 30 seconds; other errors fail immediately, and later statements continue to check the user’s actual permissions.

Validation

  • Local task-workspace results: PipeSinkSubtaskTest 11/11; Pipe dual-cluster IT 1/1; pipe lifecycle IT 1/1; TableSimpleIT and TableClusterIT 4/4 each.
  • Spotless and diff checks passed.
  • These tests were run in the task workspace before the isolated master-based candidate was prepared; remote CI has not run.

@Caideyipi

Copy link
Copy Markdown
Collaborator Author

Re-review summary: No actionable findings; no fixes were needed in this round.

  • Reviewed baseline: origin/master at edf4b4ddc329700acd3c19a4d7e7a6bb05588a23.
  • Reviewed workspace revision: d5c15340c13406d2ed69fa1237efb1141f7e21be. The published candidate contains the same four changed Java files and is based directly on the reviewed baseline.
  • Local task-workspace verification: PipeSinkSubtaskTest 11/11; Pipe dual-cluster IT 1/1; pipe lifecycle IT 1/1; TableSimpleIT and TableClusterIT 4/4 each. Spotless and diff checks passed.
  • Final local candidate SHA and confirmed fork/PR head SHA: 5f28c4cefc4cd3775c50d05a8f726e812d310fde.
  • Remote CI has not run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant