Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 7505305 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Architecture diagram
sequenceDiagram
participant User as CLI User
participant FetchCmd as Fetch Command
participant CtxResolver as resolveContextRefOrFail
participant AliasStore as Local Alias Store
participant BBClient as Browserbase Client
participant BBFetch as Browserbase Fetch API
Note over User,BBFetch: Authenticated Fetch Flow
User->>FetchCmd: browse cloud fetch <url> --context-id <id|name>
alt No --context-id flag
FetchCmd->>BBClient: createBrowserbaseClient()
FetchCmd->>BBClient: fetchAPI.create({url, format})
BBClient->>BBFetch: POST /v1/fetch
BBFetch-->>FetchCmd: FetchResponse
else --context-id provided
FetchCmd->>CtxResolver: resolveContextRefOrFail(ref)
alt ref is a UUID
CtxResolver->>CtxResolver: Validate UUID format
CtxResolver-->>FetchCmd: Return UUID as-is
else ref is a saved alias
CtxResolver->>AliasStore: Lookup saved context alias
AliasStore-->>CtxResolver: Context ID
else ref is unknown (typo)
CtxResolver->>AliasStore: Check for close matches
Altos-->>CtxResolver: No match found
CtxResolver-->>FetchCmd: Error: "No saved context named..."
FetchCmd-->>User: CLI error with suggestion
Note over User,FetchCmd: Request aborted before API call
end
CtxResolver-->>FetchCmd: Resolved contextId
FetchCmd->>BBClient: createBrowserbaseClient()
FetchCmd->>BBClient: fetchAPI.create({url, contextId, format})
BBClient->>BBFetch: POST /v1/fetch
Note over BBFetch: Fetch API uses saved context cookies
BBFetch-->>BBClient: FetchResponse with authenticated content
end
BBClient-->>FetchCmd: Result
FetchCmd->>User: Output (raw/markdown/json/file)
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browse cloud fetchcan now reuse a saved Browserbase login with--context-id <id|name>. Context names resolve through the existing local aliases; requests without the flag keep their current behavior. Raw, Markdown, JSON extraction, and file output all remain available.Uses Browserbase SDK 2.23.0, updates CLI help and the bundled Browse skill, and includes a minor changeset. The SDK's exact release is included in the workspace's release-age exceptions so the new dependency can install.
Validation:
Public feature reference: Authenticated Fetch.