Repository navigation
Conversation
…ytecodealliance#1658) Previously, user class header files (`exports-*.h`) were included at the top of `<world>_cpp.h`. When an exported resource method or constructor accepted or returned records or variants defined in the interface, the user class header failed to compile because the WIT types had not been declared yet. This commit resolves the issue by: 1. Moving user class file includes (`exports-*.h`) to the bottom of the header, ensuring all records and types are fully defined beforehand. 2. Forward-declaring exported resource classes in their respective namespaces so types and functions in the world header can reference them. 3. Referring to owned handles of exported resources as `wit::ResourceExportBase<Resource>::Owned` instead of `Resource::Owned` in the header, which is valid for incomplete forward-declared types. 4. Merging dependencies from user class files so helper headers like `wit.h` are included and emitted. Closes bytecodealliance#1658.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, user class header files (
exports-*.h) were included at the top of<world>_cpp.h. When an exported resource method or constructor accepted or returned records or variants defined in the interface, the user class header failed to compile because the WIT types had not been declared yet.This commit resolves the issue by:
exports-*.h) to the bottom of the header, ensuring all records and types are fully defined beforehand.wit::ResourceExportBase<Resource>::Ownedinstead ofResource::Ownedin the header, which is valid for incomplete forward-declared types.wit.hare included and emitted.Closes #1658.