Skip to content

fix(dev-server): pass request log suppression via fastify logController #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannyhw merged 1 commit into from
Oct 22, 2026
Merged

fix(dev-server): pass request log suppression via fastify logController #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dev-server-log-controller.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@callstack/repack-dev-server": patch
---

Silence the fastify `FSTDEP023` deprecation warning printed on every dev server start by passing request log suppression through fastify's `logController` option instead of the deprecated top-level `disableRequestLogging` option
9 changes: 7 additions & 2 deletions packages/dev-server/src/createServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Writable } from 'node:stream';
import util from 'node:util';
import middie from '@fastify/middie';
import fastifySensible from '@fastify/sensible';
import Fastify from 'fastify';
import Fastify, { LogController } from 'fastify';
import { createProxyMiddleware } from 'http-proxy-middleware';
import apiPlugin from './plugins/api/apiPlugin.js';
import compilerPlugin from './plugins/compiler/compilerPlugin.js';
Expand Down Expand Up @@ -32,7 +32,12 @@ export async function createServer(config: Server.Config) {
// to `server.close()`, which only closes them on Node 19+. Force-closing
// keeps `stop()` from hanging on Node 18.
forceCloseConnections: true,
disableRequestLogging: options.disableRequestLogging,
// The top-level `disableRequestLogging` option is deprecated (FSTDEP023).
// `LogController` only gates per-request log lines; everything else still
// goes through the `logger` stream below.
logController: new LogController({
disableRequestLogging: options.disableRequestLogging,
}),
logger: {
level: 'trace',
stream: new Writable({
Expand Down
Loading