[V3RON]

Closes #1018

Status

Implement: done Review: passed (round 2 and a fix-check) Hardware: unavailable (disk 15.0 GiB free, the lane needs 15; the physical line needs a person at the phone) Gate: waiting for the stack
Next: needs-hardware. Run the Done when lines 2 and 3 on a machine with disk space and a person at an Android phone

Assumptions

• Assumption: orientation in 0x82 — landscape_left when wider than tall, else portrait; the size read cannot tell the two landscapes apart.
• Assumption: which modifier events carry meta bits? — a modifier's own down event carries them and its up event does not, as Android's events do.
• Assumption: how is back sent? — as keycode 4 (down, up), not scrcpy's back-or-screen-on packet, so it never wakes a dark screen.
• Assumption: when does the 15 s start budget begin? — at the server's spawn, as the stream's does.
• Assumption: "logged once" for a failing size read — one warn when reads start failing, again only after a read has succeeded in between.
• Assumption: how is agent-device's snapshot --json read? — defensively (rect, identifier) in the slow-lane case, which was not run.

Review

Spec review: 1 blocking, 1 fixed, 0 notes. Code review: 2 blocking, 1 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 2. Tokens: 24.7M.
Runs: 12. Cost USD: 6.9443. Agent seconds: 4851.
Assessment: complete

Rejected:

• code: the manual physical-phone test passes without recording the person's confirmation — Done when 3 makes the person's eye the check, and code cannot see it [nonblocking]

Done when

• The three Tests lines pass in pnpm test. — src/drivers/android/input/device-input.test.ts, 4/4
• On an emulator, e2e/slow-agent-device.test.ts opens a lease and the Appduct fixture through agent-device, opens WS /v1/leases/{id}/input, gets 0x83 and 0x82, taps the centre of tab-status as agent-device's snapshot places it (as a fraction of the screen size in the same snapshot --json), and the next snapshot shows the Status tab's screen (slow lane, Android emulator). The case is skipped on iOS until iOS simulator input through the HID injector #1019. — slow lane on 0f73f1e, 2026-10-27: passed (34 passed, 1 skipped)
• With a person at the phone, e2e/slow-android-physical-manual.test.ts sends a tap and the person confirms it landed (slow lane, physical Android, person at the phone). — run by the maintainer at the phone on 0f73f1e, 2026-10-27: green
• watching-the-screen.mdx lists what input does on Android. — new Android section

Written by an agent.

[V3RON]

Decision taken

The audit found four behaviours in the Android device input that no test catches, and one row in the spec's failure-mode table that was not built. For each, the options were to add a row to the matching Tests line (taken) or leave it untested. All were taken, because each one is something a caller would see:

1. A position at fraction 1 lands on the last pixel (x = width - 1). Without the clamp, a tap on the screen's edge falls off it.
2. A scroll delta past 16 wheel units is clamped to 16.
3. After a successful open, close stops the size reads, ends the scrcpy server and removes the jar. Only cleanup after a failed open is tested today. Without this, a closed input would leave a server running on the device.
4. No second size read starts while one is running. Without this, a slow dumpsys would pile up reads.
5. A failing size read keeps the last size and is logged once. The spec's failure-mode table already says this, but it was not built.

None of these change behaviour the spec describes. To revert, delete the rows (and the logger for 5). Folded into #1018's Tests, marked pending the maintainer.

Written by an agent.

[V3RON]

Review ledger

Round 1: 312838f
Round 2: 6ebf7e9
Round fix-check: 0f73f1e

Runs: 12. Cost USD: 6.9443. Agent seconds: 4851.
Tokens input 486, output 168303, cache read 18144565, cache write 974465.
- build implementer: claude-sonnet-5-5 2737 s $2.4654
- audit implementer: claude-sonnet-5-5 307 s $0.4531
- build implementer: claude-sonnet-5-5 242 s $0.3547
- review 1 reviewer: claude-sonnet-5-5 575 s $0.3833
- review 1 code-reviewer both: claude-opus-5-5 475 s $2.0197
- review 1 spec-reviewer: claude-sonnet-5-5 39 s $0.2866
- review 1 claims-reviewer: claude-sonnet-5-5 72 s $0.2338
- fix 1 implementer: claude-sonnet-5-5 178 s $0.2956
- review 2 reviewer: claude-sonnet-5-5 112 s $0.1803
- fix 2 implementer: claude-sonnet-5-5 47 s $0.0848
- review fix-check reviewer: claude-sonnet-5-5 55 s $0.1279
- hardware hardware-verifier: claude-sonnet-5-5 12 s $0.0591
Finding outcomes: {"duplicate":1,"fixed":3,"nonblocking":1}. Classes: {"comment cites unsupporting source":1,"manual test unrecorded confirmation":1,"spec line unproven":2,"testing 2":1}.

{"findings":[{"id":"R1","role":"code","class":"testing 2","outcome":"fixed","path":"src/drivers/android/input/device-input.test.ts","round":"1","fix":"36da013f06dd7f6b15f12daa8d82963ea2f29b8f"},{"id":"R2","role":"spec","class":"spec line unproven","outcome":"fixed","path":"e2e/slow-agent-device.test.ts","round":"1","fix":"7c4d588d7569377616bee9df48904cd9e3ce5a15"},{"id":"R3","role":"code","class":"spec line unproven","outcome":"duplicate","path":"e2e/slow-agent-device.test.ts","round":"1","canonicalId":"R2"},{"id":"R4","role":"code","class":"manual test unrecorded confirmation","outcome":"nonblocking","path":"e2e/slow-android-physical-manual.test.ts","round":"1"},{"id":"R5","role":"claims","class":"comment cites unsupporting source","outcome":"fixed","path":"e2e/slow-agent-device.test.ts","round":"2","fix":"0f73f1e58df91d0bb6dd3181275bb03f11247736"}]}

Written by an agent.