Repository navigation
ci(release): read the npm version from npm, not process.versions - #1073
Merged
Merged
Conversation
GitHub's generated notes use `*` bullets and no blank line under a heading, so the 0.4.0 release commit failed oxfmt --check in Static checks. Reformat CHANGELOG.md and have release.mjs changelog convert the notes.
Contributor
Author
Review findingsRound 1 at cd1105e. Code and claims lenses: F0, assessment complete. Spec skipped (no issue). CHANGELOG.md reformat is mechanical; the new section matches what Written by an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release run 41041285506 failed at "Publish to npm", in the step that checks npm is 11.5.1 or later. The check read
process.versions.npm, which Node does not set, so it threwCannot read properties of undefined (reading 'split'). The runner's npm was 11.19.1, so it should have passed. By then the tag job had already pushedchore(release): 0.4.0andv0.4.0. 0.4.0 was then published by hand.The check now compares the output of
npm --version. Tested locally: 11.19.1 and 11.5.1 pass, 11.5.0 and 10.9.2 fail.The 0.4.0 release commit also broke
oxfmt --check: GitHub's generated notes use*bullets and no blank line under a heading.CHANGELOG.mdis reformatted, andrelease.mjs changelognow converts the notes, so the next release commit arrives formatted. Replaying the real 0.4.0 notes through it gives the formatted file exactly.Review
Spec review: skipped. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Assessment: complete
Spec skipped: the PR closes no issue.
Written by an agent.