Repository navigation
chore(ci): keep the release token out of the push URL; website install without scripts - #889
Merged
Merged
Conversation
Contributor
Author
Review (maintainer's agent, round 1)No blocking findings.
Notes, no change needed: the Playwright browser revision follows the locked |
This was referenced Oct 23, 2026
V3RON
marked this pull request as ready for review
October 26, 2026 09:46
V3RON
force-pushed
the
security/ci-hygiene
branch
from
October 26, 2026 10:29
c35d587 to
b168e30
Compare
…l without scripts (#889)
V3RON
force-pushed
the
security/ci-hygiene
branch
from
October 26, 2026 14:25
b168e30 to
da64a99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI hardening fixes. The Release workflow no longer puts
GITHUB_TOKENin the push URL. The website job installs with--ignore-scripts, like every other job.Changes
.github/workflows/release.yml(Push step): the remote is plainhttps://github.com/${GITHUB_REPOSITORY}.git. The token goes as theAUTHORIZATION: basic …extraheader that actions/checkout v7.0.1 uses, set throughGIT_CONFIG_COUNT/GIT_CONFIG_KEY_0/GIT_CONFIG_VALUE_0, so it is in neither the URL nor git's argv. The base64 value goes to::add-mask::.--atomicand the lease stay..github/workflows/website.yml:pnpm install --frozen-lockfile --ignore-scripts.src/source-hygiene.test.ts: every workflowpnpm installpasses--ignore-scripts; no URL holds a credential; the Release push keeps the token inGIT_CONFIG_*, plus--atomic, the lease and the refspecs.Verified
git pushwith only theGIT_CONFIG_*variables set.check-openapiok).playwright1.63.0 already fixes the Chromium build.Assumptions
git -cor throughGIT_CONFIG_*environment variables? —GIT_CONFIG_*, because-cstill puts the base64 token in git's argv.Review
Spec review: skipped. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: skipped.
Rounds: 1. Tokens: n/a.
One combined review by the maintainer's agent on 2026-10-22 (comment below); no blocking findings.
Rebased onto
maine1f2f43 on 2026-10-26 as one commit. Conflict insrc/source-hygiene.test.ts: main's vendored-inventory tests and this PR's workflow tests kept side by side.Written by an agent.