Repository navigation
feat(modules): a standalone worker writes a private agent-device profile for local agents - #963
Merged
Merged
Conversation
Contributor
Author
Decision takenQuestion: #956 says the profile is written before HTTP listens, but no test at the Options:
Taken: keep the order and add the test (a new Tests line on #956). This matches the spec and the code as built, and it is the easiest to reverse. Reverting: delete that Tests line and its test. Written by an agent. |
Contributor
Author
Review ledgerRound 1: baea24d {"findings":[{"id":"R1","role":"claims","class":"joined worker writes no profile claim","outcome":"incorrect","path":"website/src/content/docs/docs/using-devices/agent-device.mdx","round":"1"}]}Written by an agent. |
V3RON
marked this pull request as ready for review
October 23, 2026 20:17
This was referenced Oct 23, 2026
V3RON
added a commit
that referenced
this pull request
Oct 24, 2026
…efault (#967) Closes #957 ### Status Implement: done (6/6 green) Review: round 2 + fix-check passed Hardware: profile case pass; full file blocked by pre-existing #971 Gate: not run (maintainer asked to stop before the gate) - [x] `pnpm exec vitest run --project unit <file>` passes for `src/core/config.test.ts`, `src/agent-device/definition.test.ts`, `src/agent-device/edge.test.ts` and `src/daemon/main.test.ts` with the lines above: run by the build and audit; the doctor.run cases wait for `starting` to end. - [x] `pnpm test:e2e` passes for the e2e files the harness change touches. CI is green: three fast e2e files run by the audit; CI green on 7253fbc (23 pass). - [ ] Slow lane: `scripts/slow-e2e.sh e2e/slow-agent-device.test.ts` passes, including the profile case: the profile case passes on iOS and Android; the file still fails one sharding case, which fails the same way on `main` (#971). - [x] The website build passes, and the docs state the new defaults: audit run; claims lens found every changed claim true. Feature #952 Completion conditions: - [x] Profile written at 0600, stable across restarts, removed when off: #963's tests. - [x] Real CLI with the profile, no token (slow lane): the profile case passed. - [x] Default standalone worker has HTTP and agent-device on; joined has both off: config and defaults tests here. - [x] No doctor finding without agent-device: doctor.run cases here. - [x] Docs page with the profile connect line, `--session`, `connect --force`, no `config set`: #963 and this PR. ## Assumptions - Assumption: the profile's `clientId` value — a constant 16-hex id (`a51a51a51a51a51a`) in the shape of agent-device's own generated profiles, so the file's bytes stay stable; agent-device 0.21.28 refuses a proxy `open` without one (decision comment on this PR). ## Review Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes. Rounds: 2. Tokens: 18.5M. Runs: 13. Cost USD: 6.6777. Agent seconds: 5579. Assessment: complete *Written by an agent.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #956
Status
Implement: done (5/5 green) Review: round 1 passed Hardware: n/a Gate: waiting for the stack
pnpm exec vitest run --project unit src/agent-device/local-profile.test.tspasses with the Tests lines: run by the build and fix runs, 5/5, and checked by the review's spec lens (one test per Tests line).using-devices/agent-device.mdxshows the profile connect line,--sessionon every command, and theconnect --forceremedy: built by the audit run; the claims lens read the page.Assumptions
none
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 13.1M.
Runs: 7. Cost USD: 3.1988. Agent seconds: 1571.
Rejected:
http.enabledon a joined worker (src/core/config.ts:800-806), so the profile step takes its off path.Assessment: complete
Written by an agent.