Skip to content

update cljs data.avl maps to return MapEntries instead of 2-elem vectors to comply with clj 1.9 and cljs 1.9.293 and later - #5

Closed
kaosko wants to merge 3 commits into
clojure:masterfrom
kaosko:master
Closed

kaosko wants to merge 3 commits into
clojure:masterfrom
kaosko:master

Conversation

@kaosko

@kaosko kaosko commented Nov 14, 2018

Copy link
Copy Markdown

Now, I understand you don't accept pull requests for data.avl but just creating this to make a note of the issue, the actual changes are trivial. PersistentVectors in clj 1.9 are not allowed as MapEntries anymore; since cljs 1.9.229 2-elem vectors are not treated as MapEntries. However, cljs-version of data.avl returns 2-elem vectors instead of MapEntries. Actual issue at https://dev.clojure.org/jira/browse/DAVL-11

@dco-lentz

Copy link
Copy Markdown

Is there any anticipated timeline for getting this merged? I can replicate the issue under ClojureScript 1.10.520.

dev:cljs.user=> (require '[clojure.data.avl :as avl])
dev:cljs.user=> (avl/sorted-set 1 2 3)

#object[TypeError TypeError: me.cljs$core$IMapEntry$_key$arity$1 is not a function]

@seancorfield

Copy link
Copy Markdown
Member

@dco-lentz The Pull Request won't be merged because Clojure Contrib projects do not accept PRs -- only patches via JIRA issues. It looks like the patch on https://clojure.atlassian.net/browse/DAVL-11 is not yet acceptable so it can't move forward yet.

@dco-lentz

Copy link
Copy Markdown

Ah, ok. I don't have access to the Jira page to comment, but It's not immediately clear to me what the issue is with the current patch. Locally, this patch is passing all tests for me both in the (existing) clj 1.9.0-beta2 cljs 1.9.946 profile and with (current) clj 1.10.0 cljs 1.10.520. Is there a clearer description of what problems remain? Apologies if I'm just misunderstanding the discussion on DAVL-11.

@seancorfield

Copy link
Copy Markdown
Member

I have no insight, other than what I see in JIRA, sorry. I just responded as a maintainer of several other Contrib libraries.

@puredanger

Copy link
Copy Markdown
Member

We don't take PRs here, but I have committed a similar fix on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants