Repository navigation
Conversation
Add Node.js 26.x to the CI matrix and widen the supported engine range. Mocha is bumped from 10.x to 11.x because Mocha 10 depends on yargs 16, whose extensionless `yargs/yargs` entry point is loaded as ESM on Node 26 and fails with "require is not defined in ES module scope". Mocha 11 uses yargs 17, which resolves correctly. Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: uhooi <the_uhooi@yahoo.co.jp>
uhooi
marked this pull request as ready for review
September 4, 2026 04:56
Contributor
|
This pull request is stale because it has been open 30 days with no activity. |
Contributor
|
Let's hold on this. We need to get LTS support first (22, then 24). Let's make a launch with the improvements before we go further |
Author
|
Resolved conflicts and run |
|
This will close issue #660 660 Node 26 LTS is here, I'm not sure what's the reason of waiting for LTS, adding node support earlier when node version becames current would be nice to have if its not breaking the build. |
Contributor
|
1/ it's a breaking change.
2/ there a bunch of other changes that can also be bundled with the next
breaking version.
Please hold until we can plan a proper v11
…-Shiva
hacker, blogger, and photographer!
http://shiv.me/
"The bravest are surely those who have the clearest vision of what is
before them, glory and danger alike, and yet notwithstanding, go out to
meet it. " - Thucydides
On Wed, Nov 11, 2026 at 5:11 AM Cem Usta ***@***.***> wrote:
*cemusta* left a comment (cloudevents/sdk-javascript#655)
<#655 (comment)>
This will close issue #660
<#660> 660
Node 26 LTS is here, I'm not sure what's the reason of waiting for LTS,
adding node support earlier when node version becames current would be nice
to have if its not breaking the build.
—
Reply to this email directly, view it on GitHub
<#655?email_source=notifications&email_token=AAAB2ZGGZ2DVHS2AX3Y3P3L5YRJNZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNZZGU2DGNBUGI2KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6795434424>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAB2ZG4IZOIJEHWIP6KPNL5YRJNZAVCNFSNUABFKJSXA33TNF2G64TZHMYTIOJWGYZDSOJZHNEXG43VMU5TKMZUGQZTINBVGEZKC5QC>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
|
If you'd like to help accelerate the merges, you are welcome to join the
discussion in the cloudevent slack channel
…-Shiva
hacker, blogger, and photographer!
http://shiv.me/
"The bravest are surely those who have the clearest vision of what is
before them, glory and danger alike, and yet notwithstanding, go out to
meet it. " - Thucydides
On Wed, Nov 11, 2026 at 9:34 AM Shivanand Velmurugan ***@***.***>
wrote:
1/ it's a breaking change.
2/ there a bunch of other changes that can also be bundled with the next
breaking version.
Please hold until we can plan a proper v11
-Shiva
hacker, blogger, and photographer!
http://shiv.me/
"The bravest are surely those who have the clearest vision of what is
before them, glory and danger alike, and yet notwithstanding, go out to
meet it. " - Thucydides
On Wed, Nov 11, 2026 at 5:11 AM Cem Usta ***@***.***> wrote:
> *cemusta* left a comment (cloudevents/sdk-javascript#655)
> <#655 (comment)>
>
> This will close issue #660
> <#660> 660
>
> Node 26 LTS is here, I'm not sure what's the reason of waiting for LTS,
> adding node support earlier when node version becames current would be nice
> to have if its not breaking the build.
>
> —
> Reply to this email directly, view it on GitHub
> <#655?email_source=notifications&email_token=AAAB2ZGGZ2DVHS2AX3Y3P3L5YRJNZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNZZGU2DGNBUGI2KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6795434424>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAB2ZG4IZOIJEHWIP6KPNL5YRJNZAVCNFSNUABFKJSXA33TNF2G64TZHMYTIOJWGYZDSOJZHNEXG43VMU5TKMZUGQZTINBVGEZKC5QC>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds Node.js 26 support.
Attention
The Mocha bump is required for the test suite to run on Node.js 26. Mocha 10
depends on yargs 16, whose extensionless
yargs/yargsentry point is loaded asESM on Node.js 26 and fails with:
Mocha 11 depends on yargs 17, which resolves correctly.
References