Repository navigation
inlineToolbar always show convertTo, inconsist behavior with config value, and cannot be removed #2833
Description
Describe a bug.
const editor = new EditorJS({
holder: 'editor',
tools: {
paragraph: {
// built-in inline tools: link, bold, italic
// disable inline tools: false,
inlineToolbar: ['bold', 'link'],
},
},
})Expected behavior:
convertTo should also follow inlineToolbar config, which control it show or hide.
Screenshots:
As you see, it even show when no convertor available.
Activity
idebenone commentedon Nov 24, 2024
Hi @zhaojjiang,
We don't see any use-case for converting the 'convert to' tool optional as of now. Could you please elaborate if you have any use-cases for us?
zhaojjiang commentedon Nov 25, 2024
@idebenone just for customize,
and as mentioned above, "convert to" should not always show even there are no conventor
neSpecc commentedon Nov 27, 2024
We should not show convertTo if there is no blocks to convert to. Seems like this logic was broken.
IhorKirei commentedon Jan 15, 2025
Many use cases why it should be configurable, for example - depending on UI or user added another custom inline tool which takes care of converting.
fix(inline-toolbar): do not show "Convert to" when there is nothing t…