Skip to content

Update jackson-core version 2.22.1 -> 2.22.4 #54

Closed

Description

@thiagooak

Patch: bump-jackson-2-22-4.patch

Acceptance test results are the same with and without applying the patch. Details below.

Tests done

Building with patch applied

[bump-jackson][~/dev/nu/transit-java]$ mvn clean test-compile test

[INFO] Scanning for projects...
[INFO] Loaded 24178 auto-discovered prefixes for remote repository central (prefixes-central.txt)
[INFO] Loaded 74 auto-discovered prefixes for remote repository apache.snapshots (prefixes-apache.snapshots.txt)
[INFO] Inspecting build with total of 1 modules
[INFO] Installing Central Publishing features

....

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.cognitect.transit.TransitJSONMachineModeTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.046 s -- in com.cognitect.transit.TransitJSONMachineModeTest
[INFO] Running com.cognitect.transit.TransitTest
":db/ident"
[INFO] Tests run: 74, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.045 s -- in com.cognitect.transit.TransitTest
[INFO] Running com.cognitect.transit.TransitMPTest
[INFO] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 s -- in com.cognitect.transit.TransitMPTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 108, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.744 s
[INFO] Finished at: 2026-10-21T19:13:32-03:00
[INFO] ------------------------------------------------------------------------

Ensuring that built version has the new version of jackson-core

[bump-jackson][~/dev/nu/transit-java]$ ./bin/classpath 
... :/Users/thiago.carvalho2/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.22.4/jackson-core-2.22.4.jar: ...

Running acceptance tests with patch

[master][~/dev/nu/transit-format]$ bin/verify -impls java > bump.txt
[master][~/dev/nu/transit-format]$ cat bump.txt
transit-java exists
transit-java classes exist
testing transit-java's json encoding skills...
running "exemplar file" test for json encoding...
running "EDN corner case" test for json encoding...
running "JSON transit corner case" test for json encoding...
Project:  transit-java / json
Command:  ../transit-java/bin/roundtrip
Results for test: exemplar-file
134 successful roundtrips
Results for test: corner-case-edn
48 successful roundtrips
Results for test: corner-case-transit-json
7 successful roundtrips
testing transit-java's json-verbose encoding skills...
running "exemplar file" test for json-verbose encoding...
running "EDN corner case" test for json-verbose encoding...
running "JSON transit corner case" test for json-verbose encoding...
Project:  transit-java / json-verbose
Command:  ../transit-java/bin/roundtrip
Results for test: exemplar-file
67 successful roundtrips
Results for test: corner-case-edn
48 successful roundtrips
Results for test: corner-case-transit-json
7 successful roundtrips
testing transit-java's msgpack encoding skills...
running "exemplar file" test for msgpack encoding...
running "EDN corner case" test for msgpack encoding...
Project:  transit-java / msgpack
Command:  ../transit-java/bin/roundtrip
Results for test: exemplar-file
67 successful roundtrips
Results for test: corner-case-edn
48 successful roundtrips

Building with master

[master][~/dev/nu/transit-java]$ mvn clean test-compile test  
[INFO] Scanning for projects...
[INFO] Loaded 24178 auto-discovered prefixes for remote repository central (prefixes-central.txt)
[INFO] Loaded 74 auto-discovered prefixes for remote repository apache.snapshots (prefixes-apache.snapshots.txt)
[INFO] Inspecting build with total of 1 modules
[INFO] Installing Central Publishing features
[INFO] 
[INFO] ---------------------< com.cognitect:transit-java >---------------------
[INFO] Building transit-java dev
[INFO]   from pom.xml

...

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.cognitect.transit.TransitJSONMachineModeTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 s -- in com.cognitect.transit.TransitJSONMachineModeTest
[INFO] Running com.cognitect.transit.TransitTest
":db/ident"
[INFO] Tests run: 74, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.046 s -- in com.cognitect.transit.TransitTest
[INFO] Running com.cognitect.transit.TransitMPTest
[INFO] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 s -- in com.cognitect.transit.TransitMPTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 108, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.601 s
[INFO] Finished at: 2026-10-21T19:15:48-03:00
[INFO] ------------------------------------------------------------------------

Running acceptance tests with master

[master][~/dev/nu/transit-format]$ bin/verify -impls java > master.txt
[master][~/dev/nu/transit-format]$ cat master.txt 
transit-java exists
transit-java classes exist
testing transit-java's json encoding skills...
running "exemplar file" test for json encoding...
running "EDN corner case" test for json encoding...
running "JSON transit corner case" test for json encoding...
Project:  transit-java / json
Command:  ../transit-java/bin/roundtrip
Results for test: exemplar-file
134 successful roundtrips
Results for test: corner-case-edn
48 successful roundtrips
Results for test: corner-case-transit-json
7 successful roundtrips
testing transit-java's json-verbose encoding skills...
running "exemplar file" test for json-verbose encoding...
running "EDN corner case" test for json-verbose encoding...
running "JSON transit corner case" test for json-verbose encoding...
Project:  transit-java / json-verbose
Command:  ../transit-java/bin/roundtrip
Results for test: exemplar-file
67 successful roundtrips
Results for test: corner-case-edn
48 successful roundtrips
Results for test: corner-case-transit-json
7 successful roundtrips
testing transit-java's msgpack encoding skills...
running "exemplar file" test for msgpack encoding...
running "EDN corner case" test for msgpack encoding...
Project:  transit-java / msgpack
Command:  ../transit-java/bin/roundtrip
Results for test: exemplar-file
67 successful roundtrips
Results for test: corner-case-edn
48 successful roundtrips

Ensuring that the output with and without the patch applied are identical

[master][~/dev/nu/transit-format]$ diff -s bump.txt master.txt
Files bump.txt and master.txt are identical

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions