Skip to content

fix: run every check in CI and make merges wait on them - #143

Merged
botandbang merged 23 commits into
mainfrom
bnb/ci-checks
Nov 10, 2026
Merged

botandbang merged 23 commits into
mainfrom
bnb/ci-checks

Conversation

@botandbang

Copy link
Copy Markdown
Contributor

Every check that runs locally now runs in CI and feeds ci-ok, the required check, and the gaps from the CI audit are filled. Cheap checks run on every PR. The expensive ones (every module's tests on Linux, macOS and Windows, 50 times the fast-check cases, external links, zizmor's online audits) run weekly, and most of them on workflow_dispatch too.

Fixed

  • CI installed a Node 27 alpha wherever it asked for current (lint, types, one test leg). Lint, types, docs and the nightly build now read .node-version, and the test matrix lists the LTS lines, 26 and 24. Both ship an npm that meets devEngines.
  • Every module's package.json declares engines.node: ">=24", the lines CI tests. Before, only translate declared one (>=18.0.0), and nothing older than 24 was tested.
  • A change to parsefiles didn't retest core or anything built on it. The path filters for core, newest, oldest, ranges, static and translate now include parsefiles/**.

Changed

  • The docs build is a reusable workflow that ci.yml calls when the docs or what they read change, so a broken docs build now fails ci-ok. Deploys still happen only on pushes to main and manual runs. The deploy job has its own concurrency group, so two pushes can't deploy over each other.
  • zizmor runs offline in a new workflows job in ci.yml, without code scanning mode, so findings fail the run. zizmor.yml keeps uploading to code scanning on pushes to main, and it now runs its online audits weekly instead of on PRs. Both pin zizmor 1.31.1 instead of the action's latest.
  • The PR title check also runs on synchronize, so it reports on every push and can be required.
  • oxlint runs with --deny-warnings.
  • ci.yml runs on a weekly schedule. A scheduled or manual run tests every module. On the weekly run, a step sets FC_NUM_RUNS=5000 and loads test/fc-num-runs.mjs through NODE_OPTIONS=--import, which raises fast-check's runs per property from 100. knip.jsonc ignores fast-check at the root, since that file loads the copy of whichever module it runs in. ranges' properties drop their own numRuns: 50, so they follow the global setting like the others.
  • The test matrix adds macOS and Windows on the weekly and manual runs. The test job runs its steps in bash, since Windows defaults to PowerShell.
  • The repository-url loop in the lint job is gone. npm run lint:workspaces does the same check, and it takes the list of published modules from release.yml instead of a copy.
  • Every module's package.json sets "type": "commonjs", which publint suggested.

Added

  • actionlint (the pinned rhysd/actionlint image, which runs shellcheck on run: blocks) in the workflows job.
  • typos in the lint job, with _typos.toml allowing Jod, Node 22's codename. A separate commit fixes the ten typos it found, plus one in the README it doesn't know.
  • lychee: offline relative-link and anchor checks in the lint job, and on the weekly run an online check of the READMEs, the docs pages and the built site.
  • npm run lint:pack (part of npm run lint): publint and Are the Types Wrong? on every module's packed tarball.
  • npm run lint:workspaces (part of npm run lint): test/workspaces.test.mjs checks that tsconfig references, dependabot's directories, release.yml's three package lists, the docs sidebar and pages, each module's LICENSE, the repository URLs of published modules, and CI's path filters (each module plus everything it loads, transitively) all match workspaces.
  • The root tsconfig.json now type-checks the tests, dev and build scripts, tools/harden and doc-kit.config.mjs, so npm run types covers them. A separate commit fixes the 332 errors this found. Most are JSDoc annotations or assert.ok narrowing. undici's fetch gets cast through unknown where tests pass it as a typeof fetch, since its types don't match the global ones. The rest are @ts-expect-error on calls that pass invalid input on purpose. core/test/combos.js passed { undiciFetch } instead of { fetch: undiciFetch }, so that test never used its custom fetch. It does now.
  • aliases has tests, a coverage script and a CI path filter. It also gets a LICENSE, which its published tarball was missing. translate gets one too.
  • actions/dependency-review-action fails a PR that adds or upgrades to a dependency with a known advisory.
  • The README lists what CI runs beyond the npm scripts.

Removed

  • The root updates script, which called a script no workspace defines, and each workspace's updates:check and updates:update. Dependabot handles updates.
  • static's prepublish script. npm 7 and later don't run it on npm pack or npm publish, so it never built anything for a release.
  • The second, identical copy of the .gitignore template.

Repo settings

These are applied separately after this merges:

  • add conventional-commit as a required check in the main ruleset
  • add a code_scanning rule for CodeQL (errors, and high or critical security alerts)
  • turn on secret scanning's non-provider patterns and validity checks

@socket-security

socket-security Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedpublint@​0.3.251001008192100
Added@​arethetypeswrong/​cli@​0.18.510010010082100

View full report

@botandbang
botandbang merged commit 0feb8a3 into main Nov 10, 2026
102 checks passed
@botandbang
botandbang deleted the bnb/ci-checks branch November 10, 2026 21:17
@nodevu-ci nodevu-ci Bot mentioned this pull request Nov 10, 2026
botandbang added a commit that referenced this pull request Nov 10, 2026
Brings in #143. Its type-checked tests now load the shared snapshot and helpers from @nodevu/fixtures, and the fixtures workspace is added to everything #143 checks lists every workspace in: the TypeScript project references (with its own tsconfig and committed types), Dependabot's directories, release.yml's package lists (as !fixtures, which uppt skips), a LICENSE, and CI's path filters. The docs check in test/workspaces.test.mjs no longer asks private workspaces for a docs page. package-lock.json is regenerated with npm.
botandbang added a commit that referenced this pull request Nov 11, 2026
Brings in #143 and #144's squash. The merge keeps main's tree plus this branch's change: core requires @nodevu/fetchindex, and core/util/prod/versions.js, core/test/versions.js and its generated types stay deleted. #143's new assertion in core/test/versions.js, that the newest release lists npm, v8, uv, zlib, openssl and modules, is already in fetchindex's tests. CI's path filters for core and the packages built on it include fetchindex/**, and package-lock.json is updated with npm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant