Repository navigation
fix: run every check in CI and make merges wait on them - #143
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Draft
botandbang
added a commit
that referenced
this pull request
Nov 10, 2026
Brings in #143. Its type-checked tests now load the shared snapshot and helpers from @nodevu/fixtures, and the fixtures workspace is added to everything #143 checks lists every workspace in: the TypeScript project references (with its own tsconfig and committed types), Dependabot's directories, release.yml's package lists (as !fixtures, which uppt skips), a LICENSE, and CI's path filters. The docs check in test/workspaces.test.mjs no longer asks private workspaces for a docs page. package-lock.json is regenerated with npm.
botandbang
added a commit
that referenced
this pull request
Nov 11, 2026
Brings in #143 and #144's squash. The merge keeps main's tree plus this branch's change: core requires @nodevu/fetchindex, and core/util/prod/versions.js, core/test/versions.js and its generated types stay deleted. #143's new assertion in core/test/versions.js, that the newest release lists npm, v8, uv, zlib, openssl and modules, is already in fetchindex's tests. CI's path filters for core and the packages built on it include fetchindex/**, and package-lock.json is updated with npm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every check that runs locally now runs in CI and feeds
ci-ok, the required check, and the gaps from the CI audit are filled. Cheap checks run on every PR. The expensive ones (every module's tests on Linux, macOS and Windows, 50 times the fast-check cases, external links, zizmor's online audits) run weekly, and most of them onworkflow_dispatchtoo.Fixed
current(lint, types, one test leg). Lint, types, docs and the nightly build now read.node-version, and the test matrix lists the LTS lines, 26 and 24. Both ship an npm that meetsdevEngines.package.jsondeclaresengines.node: ">=24", the lines CI tests. Before, only translate declared one (>=18.0.0), and nothing older than 24 was tested.parsefilesdidn't retestcoreor anything built on it. The path filters for core, newest, oldest, ranges, static and translate now includeparsefiles/**.Changed
ci.ymlcalls when the docs or what they read change, so a broken docs build now failsci-ok. Deploys still happen only on pushes to main and manual runs. The deploy job has its own concurrency group, so two pushes can't deploy over each other.workflowsjob inci.yml, without code scanning mode, so findings fail the run.zizmor.ymlkeeps uploading to code scanning on pushes to main, and it now runs its online audits weekly instead of on PRs. Both pin zizmor 1.31.1 instead of the action'slatest.synchronize, so it reports on every push and can be required.oxlintruns with--deny-warnings.ci.ymlruns on a weekly schedule. A scheduled or manual run tests every module. On the weekly run, a step setsFC_NUM_RUNS=5000and loadstest/fc-num-runs.mjsthroughNODE_OPTIONS=--import, which raises fast-check's runs per property from 100. knip.jsonc ignoresfast-checkat the root, since that file loads the copy of whichever module it runs in. ranges' properties drop their ownnumRuns: 50, so they follow the global setting like the others.npm run lint:workspacesdoes the same check, and it takes the list of published modules from release.yml instead of a copy.package.jsonsets"type": "commonjs", which publint suggested.Added
rhysd/actionlintimage, which runs shellcheck onrun:blocks) in theworkflowsjob._typos.tomlallowingJod, Node 22's codename. A separate commit fixes the ten typos it found, plus one in the README it doesn't know.npm run lint:pack(part ofnpm run lint): publint and Are the Types Wrong? on every module's packed tarball.npm run lint:workspaces(part ofnpm run lint):test/workspaces.test.mjschecks that tsconfig references, dependabot's directories, release.yml's three package lists, the docs sidebar and pages, each module's LICENSE, the repository URLs of published modules, and CI's path filters (each module plus everything it loads, transitively) all matchworkspaces.tsconfig.jsonnow type-checks the tests, dev and build scripts,tools/hardenanddoc-kit.config.mjs, sonpm run typescovers them. A separate commit fixes the 332 errors this found. Most are JSDoc annotations orassert.oknarrowing. undici'sfetchgets cast throughunknownwhere tests pass it as atypeof fetch, since its types don't match the global ones. The rest are@ts-expect-erroron calls that pass invalid input on purpose.core/test/combos.jspassed{ undiciFetch }instead of{ fetch: undiciFetch }, so that test never used its custom fetch. It does now.aliaseshas tests, a coverage script and a CI path filter. It also gets a LICENSE, which its published tarball was missing. translate gets one too.actions/dependency-review-actionfails a PR that adds or upgrades to a dependency with a known advisory.Removed
updatesscript, which called a script no workspace defines, and each workspace'supdates:checkandupdates:update. Dependabot handles updates.prepublishscript. npm 7 and later don't run it onnpm packornpm publish, so it never built anything for a release..gitignoretemplate.Repo settings
These are applied separately after this merges:
conventional-commitas a required check in themainrulesetcode_scanningrule for CodeQL (errors, and high or critical security alerts)