Repository navigation
[6.1.8 Cherry-pick] Fix HasRows detection after multiple INFO tokens - #4898
Merged
Merged
Conversation
* Fix HasRows detection after multiple INFO tokens Consume consecutive INFO tokens in both reader metadata paths while preserving deferred informational events. Add sync/async regression coverage for populated and empty results, SQL Server integration coverage, and updated HasRows documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Cover alternate metadata HasRows processing Add crafted ALTMETADATA and ALTROW responses with sync/async coverage, regular-row and alternate-only cases, and deferred INFO delivery assertions. Verify the regression detects removal of the alternate metadata fix. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Guard HasRows INFO loops against closed parsers Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Expand HasRows response coverage and share INFO processing Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Preserve HasRows behavior for closed parsers Stop the INFO loop without throwing when the parser is closed or broken, retaining the prior no-row result and unchanged token state. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Clarify HasRows regression scenarios Split the response matrix into named sync and async theories with typed data and explicit setup/assertion sections. Preserve the full wire matrix and driver behavior while clarifying null arguments and private helper placement. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Handle INFO tokens before ORDER in HasRows detection Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 81f603e3-97ec-45ff-9bb0-52ab65ba5e3c * Guard HasRows ORDER processing against unavailable parsers Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7c53fcdb-6763-414c-84c1-104507dd7379 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 81f603e3-97ec-45ff-9bb0-52ab65ba5e3c Copilot-Session: 7c53fcdb-6763-414c-84c1-104507dd7379
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
priyankatiwari08
previously approved these changes
Oct 22, 2026
priyankatiwari08
left a comment
Contributor
There was a problem hiding this comment.
Looks good — diff identical to merged #4773
Contributor
|
/azp run |
mdaigle
enabled auto-merge (squash)
October 22, 2026 20:38
|
Azure Pipelines: Successfully started running 2 pipeline(s). 3 pipeline(s) were filtered out due to trigger conditions. |
Closed
Preserve .NET Framework's synthesized aggregate name and .NET's unnamed column behavior in HasRows regression tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: df53500a-a50f-41f8-bd18-336714b03cee
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 3 pipeline(s) were filtered out due to trigger conditions. |
apoorvdeshmukh
approved these changes
Oct 26, 2026
paulmedynski
approved these changes
Oct 26, 2026
This was referenced Oct 28, 2026
Closed
Merged
This was referenced Nov 2, 2026
Bump Microsoft.Data.SqlClient from 6.1.7 to 7.1.1
broleks/blazorNETprojectstarterwithauthorization#6
Open
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #4773 (06d0e99) into
release/6.1.