Repository navigation
Add netstandard2.0 buildTransitive props and targets to Microsoft.Extensions.Telemetry.Abstractions (#7416) - #7906
Open
Manish-1kumar wants to merge 1 commit into
Conversation
…ensions.Telemetry.Abstractions (dotnet#7416)
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1660453&view=codecoverage-tab |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Microsoft.Extensions.Telemetry.Abstractions targets $(NetCoreTargetFrameworks);netstandard2.0;net462 and packages custom buildTransitive props and targets to disable the default Microsoft.Extensions.Logging.Abstractions source generator in consuming projects.
However, �uildTransitive only contained
et6.0 and
et8.0 folders. As reported in #7416 and #6733, consuming projects targeting
etstandard2.0 or
etstandard2.1 did not receive these targets, resulting in CS0757: A partial method may not have multiple implementing declarations when both source generators ran simultaneously.
This PR adds �uildTransitive/netstandard2.0/Microsoft.Extensions.Telemetry.Abstractions.props and .targets, aligning with the existing
et6.0 and
et8.0 configurations.
Fixes #7416
Resolves #6733
Customer Impact
Libraries and applications multi-targeting
etstandard2.0 or
etstandard2.1 that consume Microsoft.Extensions.Telemetry.Abstractions or Microsoft.Extensions.Http.Resilience can build cleanly without duplicate generator collision errors.
Regression?
No. Missing packaging asset for netstandard.
Risk
Low. Adds targeted MSBuild props/targets for
etstandard2.0 consumers matching what already exists for
et6.0/
et8.0.
Testing
Microsoft Reviewers: Open in CodeFlow