Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4d46afcf-3229-49c2-83ca-e59c727e3fe8
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4d46afcf-3229-49c2-83ca-e59c727e3fe8
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Coverage filtering can suppress relevant findings by missing projects that link changed source files and omitting shared tooling and build paths from the full-comment fallback.
2 open issues
What changed in this PR
This PR focuses coverage-bot comments on projects relevant to a pull request while preserving repository-wide validation and the complete saved coverage report.
Changes:
- Filters comments by changed-file ownership and direct source references from changed tests, with shared-change fallbacks.
- Adds coverage-script tests and CI result publishing, deferring test failure until after other build steps.
- Fetches the PR merge commit’s parent for changed-file comparisons.
| File | Description |
|---|---|
| eng/scripts/ValidateProjectCoverage.Tests.ps1 | Tests filtering, full-report preservation, and shallow-checkout comparisons. |
| eng/scripts/ValidateProjectCoverage.ps1 | Separates filtered comments from repository-wide coverage reporting. |
| eng/pipelines/templates/VerifyCoverageReport.yml | Supplies the comparison revision for public PR builds. |
| eng/pipelines/templates/BuildAndTest.yml | Runs pinned Pester tests and publishes results with failure checks. |
| azure-pipelines.yml | Increases coverage checkout depth to include the parent commit. |
| azure-pipelines-unofficial.yml | Increases coverage checkout depth to include the parent commit. |
| azure-pipelines-public.yml | Increases coverage checkout depth to include the parent commit. |
Review effort: Balanced
Comment on lines
+96
to
+98
| $owners = @($projects | Where-Object { | ||
| $fullPath.StartsWith($_.DirectoryName + [System.IO.Path]::DirectorySeparatorChar, [System.StringComparison]::Ordinal) | ||
| } | Sort-Object { $_.DirectoryName.Length } -Descending) |
Member
Author
There was a problem hiding this comment.
I don't think doing this is worth it, especially since it requires attempting to interpret MSBuild wildcards.
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1671414&view=codecoverage-tab |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4d46afcf-3229-49c2-83ca-e59c727e3fe8
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1673141&view=codecoverage-tab |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The coverage bot currently reports findings for every project in the repository on each PR and each push, including coverage shortfalls and threshold-increase suggestions in projects the PR did not touch. This buries relevant feedback in unrelated findings and can make existing coverage gaps look like regressions introduced by the PR.
Filter the GitHub comment to PR-relevant projects so authors can focus on actionable feedback, while keeping repository-wide validation and the complete Azure DevOps coverage report unchanged.
Changes
If you think running script tests on CI or even having script tests in the first place is unnecessary, I can remove those.
Validation
Note
This PR was generated with GitHub Copilot.
Microsoft Reviewers: Open in CodeFlow