Skip to content

Reject one-part channels with a clear error #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
celinhodaltro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reject one-part channels with a clear error #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/dotnet-install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,10 @@ function Get-NormalizedChannel([string]$Channel) {
Say-Warning 'Using branch name with -Channel option is no longer supported with newer releases. Use -Quality option with a channel in X.Y format instead, such as "-Channel 5.0 -Quality Daily."'
}

if ($Channel -match '^\d+$') {
throw "'$Channel' is not a supported value for -Channel option. Supported values are: STS, LTS, a two-part version such as '10.0', or a three-part SDK feature band such as '10.0.1xx'. Did you mean '-Channel $Channel.0'? If you think this is a bug, report it at https://github.com/dotnet/install-scripts/issues."
}

switch ($Channel) {
{ $_ -eq "lts" } { return "LTS" }
{ $_ -eq "sts" } { return "STS" }
Expand Down
5 changes: 5 additions & 0 deletions src/dotnet-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,11 @@ get_normalized_channel() {
say_warning 'Using branch name with -Channel option is no longer supported with newer releases. Use -Quality option with a channel in X.Y format instead.';
fi

if [[ $channel =~ ^[0-9]+$ ]]; then
say_err "'$channel' is not a supported value for --channel option. Supported values are: STS, LTS, a two-part version such as '10.0', or a three-part SDK feature band such as '10.0.1xx'. Did you mean '-Channel $channel.0'? If you think this is a bug, report it at https://github.com/dotnet/install-scripts/issues."
return 1
fi

if [ ! -z "$channel" ]; then
case "$channel" in
lts)
Expand Down