Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementations match the documented behavior and include focused regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes cloning behavior for default-value appends and enumerable index maps.
Changes:
- Appends default
VBuffer<T>values during cloning. - Allows enumerable index maps longer than the source column.
- Adds regression tests for both behaviors.
| File | Description |
|---|---|
src/Microsoft.Data.Analysis/DataFrameColumn.cs |
Clarifies clone append semantics. |
src/Microsoft.Data.Analysis/DataFrameColumns/VBufferDataFrameColumn.cs |
Implements default-value appends. |
src/Microsoft.Data.Analysis/PrimitiveDataFrameColumn.cs |
Removes the source-length limit on enumerable maps. |
test/Microsoft.Data.Analysis.Tests/VBufferColumnTests.cs |
Tests appended default vectors. |
test/Microsoft.Data.Analysis.Tests/PrimitiveDataFrameColumnTests.cs |
Tests longer enumerable maps. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rosebyte
approved these changes
Oct 13, 2026
Honor appended values for VBuffer clones and allow enumerable index maps to produce more values than the source column. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
svick
force-pushed
the
svick/fix-dataframe-clone-behavior
branch
from
October 14, 2026 13:38
33dd381 to
75c1156
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7754 +/- ##
=======================================
Coverage 69.99% 70.00%
=======================================
Files 1419 1419
Lines 272761 272787 +26
Branches 27579 27581 +2
=======================================
+ Hits 190914 190952 +38
+ Misses 73664 73649 -15
- Partials 8183 8186 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
This PR needs to be re-approved, because I merged the previous PR in the PR stack. |
matouskozak
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numberOfNullsToAppendseemed like worse optionsAddresses the two findings from the review on #7750.
Validation
Manually ran a CI build. CI is skipped for this PR because it doesn't target main, because it's a stacked PR.