Repository navigation
Throw ArgumentNullException from DataFrame binary operators when the DataFrame is null - #7851
Conversation
…DataFrame is null Signed-off-by: ShryukGrandhi <85529990+ShryukGrandhi@users.noreply.github.com>
|
@ShryukGrandhi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7851 +/- ##
==========================================
- Coverage 70.81% 70.74% -0.08%
==========================================
Files 1421 1421
Lines 280000 280351 +351
Branches 27620 27732 +112
==========================================
+ Hits 198294 198342 +48
- Misses 73548 73823 +275
- Partials 8158 8186 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes #5677
The scalar operators on
DataFrame(df + 1,1 + df,df << 1, etc.) call straight into the instance method, so passing a nullDataFramethrows aNullReferenceExceptionfrom inside the library. As suggested in the triage comment, these now throwArgumentNullExceptionwithParamNameset todf.The
booloverload mentioned in the issue no longer exists, sinceboolis excluded from the numeric operators, but every other operator overload had the same problem.Changes:
DataFrame.BinaryOperators.tt: add a null check ondfto the three operator templates (scalar, reverse scalar and shift).DataFrame.BinaryOperators.cs: the matching change in the generated file, applied to all 112 operators. The only differences from the existing file are the added checks.TestBinaryOperatorsWithNullDataFramecovers the arithmetic, reverse and shift operators with a nullDataFrame.No public API is added or changed. Only the exception type thrown for a null argument is different.
Testing:
Before the fix, the new test failed with
NullReferenceException. After the fix, it passes.dotnet test test/Microsoft.Data.Analysis.Tests(net8.0, macOS arm64): 1779 passed, 6 skipped, 0 failed.dotnet format whitespace --verify-no-changeson the changed files: clean.Descriptive title
Associated issue: NullReferenceException in DataFrame.BinaryOperators #5677
Public API changes: N/A
Change description
Tests included