Repository navigation
Allow choosing the HTTP client pool connection selection strategy - #6469
Open
ninadsutrave wants to merge 1 commit into
Open
ninadsutrave wants to merge 1 commit into
ninadsutrave wants to merge 1 commit into
Conversation
See eclipse-vertx#6312 Signed-off-by: Ninad Sutrave <ninadsutrave@gmail.com> Assisted-by: Anthropic Claude (claude-opus-5-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6312
Adds
PoolOptions#setConnectionSelectionwithLIFO(default, current behaviour),ROUND_ROBINandLEAST_REQUESTS, so the HTTP client can spread requests across pooled connections instead of always reusing the same one.A couple of things worth pointing out:
PoolOptions(JsonObject)now callsthis()first, likeHttp2Settings, so missing keys fall back to defaults. Without it, a JSON config withoutconnectionSelectionwould leave it null.Happy to change the naming or the API shape if you had something else in mind.