Repository navigation
Conversation
This was referenced Oct 16, 2026
cursor
Bot
force-pushed
the
cursor/intel-install-gate-1297
branch
from
October 16, 2026 11:57
02c09d0 to
3e94f2f
Compare
cursor
Bot
force-pushed
the
cursor/intel-signer-admit-1297
branch
from
October 16, 2026 11:59
11a7d02 to
9713956
Compare
cursor
Bot
force-pushed
the
cursor/intel-install-gate-1297
branch
from
October 16, 2026 12:20
3e94f2f to
58a76ac
Compare
cursor
Bot
force-pushed
the
cursor/intel-signer-admit-1297
branch
from
October 16, 2026 12:20
9713956 to
9cce590
Compare
prepare() and the artifact prefix now use the platform set captured from COMPONENT_KEYS at import. x86_64-darwin stays outside that set. A later mutation of COMPONENT_KEYS does not admit a platform, and prepare() refuses it with "release platforms refused" before it fetches artifacts. Co-authored-by: Sash <SashaMIT@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/intel-signer-admit-1297
branch
from
October 16, 2026 14:05
9cce590 to
b51bda5
Compare
release-signer.py keeps this branch's RELEASE_PLATFORMS and early check and drops the base's second allowlist; package-release-binaries-test.py keeps the base's test and asserts the darwin-amd64 release id is outside RELEASE_PLATFORMS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
zip 9 for RUSTSEC-2026-0367/0368/0369 so cargo-audit passes. The base already merges fix/zip-9-rustsec; merging the base keeps this PR's diff against it unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
Brings the plain Intel Mac stop message from #398. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
Brings in the ported held-lock journal test fix (develop 5051505) so test-capsules stops flaking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
Brings in #398's fixes: the plain Intel Mac stop, Rosetta as Apple silicon, and the installer using only the bytes it checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
Contributor
Author
|
Generated by Claude Code |
Contributor
Author
|
Round 3 review: PASS (B). One signer allowlist works. Inherits the #398 decision. |
Brings in #398's round-4 commits: the swapped-Runtime test swaps the real download on macOS too (f8defe8), and the staged Runtime runs from one held file, not by path (112e168). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
Brings in #394's one-step flock ownership proof, the subordinate lane on the same proof, and a held lock with an unreadable record counting as held (4bb19dc), through #398. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
Contributor
Author
|
Round 4 at f4cf806: PASS (A). 88/88; genuine merge. |
Brings in #398's portable swapped-Runtime test (da63c23: the Linux case mocks a GNU-like mktemp instead of using the host's), and, through #397 and #395, #394's statement that the host lock proves possession, not that the holder is the gateway (13cdcad). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6Qn9RX7LDqrwiAfNC2F2K
Contributor
Author
|
Round 5 at 39f5338: PASS (A). Genuine merge, own diff unchanged; signer suite 88/88. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack: #395 ← #397 ← #398 (
cursor/intel-install-gate-1297, this PR's base) ← #399 (this).Head:
39f53389. Draft. Do not merge.prepare()and the release artifact prefix use one platform set,RELEASE_PLATFORMS, captured fromCOMPONENT_KEYSat import (scripts/release-signer.py:456). That set isx86_64-linux,aarch64-linux, andaarch64-darwin.x86_64-darwinstays outside it.prepare()checks it beforeverify_release_provenance(:1074-1077) and again on the parsed release (:1097).A test adds
x86_64-darwintoCOMPONENT_KEYSafter import.prepare()still raisesrelease platforms refusedbefore it fetches artifacts. The prefixrelease-x86_64-darwinis refused.This pull request does not widen the production signer. A signed Intel download waits for a producer, a
darwin-amd64payload set, and a Home journey in one later change.What this PR carries against its base: only
b51bda59(scripts/release-signer.py,scripts/release-signer-test.py,scripts/package-release-binaries-test.py; 3 files). Everything else comes from merges, never a rebase:095084ffmerged Stop Intel Mac before release lookup and pin the verified head CID #398 at343da76a. Conflicts:scripts/release-signer.pykept this branch'sRELEASE_PLATFORMSand early check and dropped the base's second allowlist (SIGNED_RELEASE_PLATFORMS), so the signer has one allowlist.scripts/package-release-binaries-test.pykept the base's packaging test and added one assertion: the release id thatdarwin-amd64maps to is not insigner.RELEASE_PLATFORMS(:134).d40a2f5e,3c5d3e16,e06de657) brought zip 9 (deps: move zip to 9.x for RUSTSEC-2026-0367/0368/0369 #417), the plain Intel stop and the held-lock journal test fix.42b91fd8merges Stop Intel Mac before release lookup and pin the verified head CID #398 at51404a76, with no conflict. It brings Stop Intel Mac before release lookup and pin the verified head CID #398's fixes: the Intel stop is exactlyIntel Mac is not supported yet., a Rosetta Terminal on Apple silicon installsaarch64-darwin, andinstall.shuses only the bytes it checked (see Stop Intel Mac before release lookup and pin the verified head CID #398).bb874fe8merges Stop Intel Mac before release lookup and pin the verified head CID #398 at29733e73, with no conflict. It brings Define the launcher contract for gateway supervision #394's36720070through Smoke the gateway health probe on Intel Mac #395 and Name the Intel Mac release package darwin-amd64 #397:/healthzand the gateway start prove that the gateway holds the lock from the held flock, not the JSON record inhost-process.lock(docs/LAUNCHER_CONTRACT.md, "What proves that this gateway holds the lock"). It also brings Smoke the gateway health probe on Intel Mac #395's macOS smoke test fixes.c647ecf7merges Stop Intel Mac before release lookup and pin the verified head CID #398 at112e168f, with no conflict. It brings Stop Intel Mac before release lookup and pin the verified head CID #398's round-4 commits: the swapped-Runtime test swaps the real download on macOS too (f8defe86), andinstall.shruns the staged Runtime from one held file, not by path (112e168f; see Stop Intel Mac before release lookup and pin the verified head CID #398). This PR's 3-file diff against its base is unchanged.f4cf806amerges Stop Intel Mac before release lookup and pin the verified head CID #398 at32f4abfd, with no conflict. It brings Define the launcher contract for gateway supervision #394's4bb19dcfthrough Smoke the gateway health probe on Intel Mac #395, Name the Intel Mac release package darwin-amd64 #397 and Stop Intel Mac before release lookup and pin the verified head CID #398: the ownership proof is one step (each registry entry keeps a second descriptor of the locked open file, and the registry mutex is held from the lookup to the end of the probe;85f3142e); the managed-runtime subordinate lane uses the same proof as/healthz, and a Home terminal gets an inherited lock descriptor,ELASTOS_GATEWAY_HOST_LOCK_FD(eed83a72); a held lock whose record cannot be read still counts as held (4bb19dcf). This PR's 3-file diff against its base is unchanged.39f53389merges Stop Intel Mac before release lookup and pin the verified head CID #398 atda63c235, with no conflict. It brings Stop Intel Mac before release lookup and pin the verified head CID #398'sda63c235(the swapped-Runtime test's Linux case mocks a GNU-likemktempinstead of using the host's, so it passes on a Mac host) and, through Name the Intel Mac release package darwin-amd64 #397 and Smoke the gateway health probe on Intel Mac #395, Define the launcher contract for gateway supervision #394's13cdcad0(the contract states that the host lock proves possession, not that the holder is the gateway) and Smoke the gateway health probe on Intel Mac #395's630efc6d(the default-command smoke test no longer depends on port 8090). This PR's 3-file diff against its base is unchanged.Tests
On
42b91fd8:On
c647ecf7(the merge above):On
f4cf806a(the merge of #398 at32f4abfd):env -i PATH=/usr/local/bin:/usr/bin:/bin python3 -I -S scripts/release-signer-test.pyOK;python3 scripts/install-bootstrap-test.pyOK (skipped=4).On
39f53389(the merge of #398 atda63c235):install-bootstrap-test.pyRan 98 tests ... OK (skipped=4)with the host's GNUmktemp, and the same with an Apple-likemktempstub first onPATH(see #398);env -i PATH=/usr/local/bin:/usr/bin:/bin HOME=$HOME python3 -I -Srelease-signer-test.py88 OK andrelease-platform-input-test.py164 OK;ci-release-policy-test.py103 OK;package-release-binaries-test.py9 OK;gateway-healthz-smoke-test.py26 OK (3 skipped);git diff --checkclean.Nothing is skipped in the signer test now:
ghis in/usr/local/binon this host, and the one skip onbb874fe8was a run whosePATHleft it out.git diff --checkclean. The signer test runs with-I -Sin a clean environment, asrelease-platform-input-test.pyruns it;release-signer.pyrefuses the TLS proxy variables this test host sets. The 3 skipped smoke cases are IPv6 (no IPv6 loopback on the test host).Negative checks from
095084ff(this PR's own change is unchanged since; re-run not repeated on later merges):release platforms refusedchecks turned intoassert:test_optimized_cli_refuses_x86_64_darwin_and_signs_nothingfails with'ValueError: package artifact prefix refused' != 'ValueError: release platforms refused'. The later prefix gate still stops the input, so nothing is signed.x86_64-darwinadded toCOMPONENT_KEYS:test_intel_package_key_prints_and_packaging_refuses_the_tarballfails with'x86_64-darwin' unexpectedly found in frozenset(...).CI
Runs 39018384842 and 39019375337 were cancelled when the next merge was pushed; run 39022807547 (
e06de657) is superseded by the push of42b91fd8. No job failed in them. Run 39033222479 (42b91fd8) was cancelled. Run 39038272177 (bb874fe8) was still in progress whenc647ecf7was pushed. The run for39f53389is the one to read.Principles check
prepare()and the artifact prefix.Intel stays C. No grade here is a merge approval. Opening this allowlist is a release decision for the team, and this draft does not make that decision.
Team issues to open
Signed x86_64-darwin artifact, darwin-amd64 payloads, and Home journey. Admitx86_64-darwinonly in the pull request that also adds the producer, the payload set, and the journey.Adversarial review for the release signer allowlist. An independent review on the exact SHA, before any later admission.install.shis asked on Stop Intel Mac before release lookup and pin the verified head CID #398; it reaches this PR through the merge. The team decided it in Follow-ups from Sasha's 0.8.0 pre-release review (#375) #434; Stamped installer: no environment or flag override of the maintainer DID #435 implements it.