Repository navigation
upath.implementations.local: fix from_uri() backport on python<3.13 - #574
Merged
Merged
Conversation
LocalPath.from_uri() on python<3.13 returned UPath(uri), i.e. a FilePath with a still percent-encoded path, instead of parsing the RFC 8089 file URI like pathlib.Path.from_uri() on 3.13+. Backport the 3.13 behaviour so type(p).from_uri(p.as_uri()) == p holds on all python versions, including UNC paths on Windows. docs: explain the difference between RFC 8089 file URIs returned by PosixUPath/WindowsUPath.as_uri() and fsspec file:// urlpaths used by FilePath, and stop recommending UPath(p.as_uri()) to switch to FilePath.
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalPath.from_uri() on python<3.13 returned UPath(uri), i.e. a FilePath with a still percent-encoded path, instead of parsing the RFC 8089 file URI like pathlib.Path.from_uri() on 3.13+. Backport the 3.13 behaviour so type(p).from_uri(p.as_uri()) == p holds on all python versions, including UNC paths on Windows.
docs: explain the difference between RFC 8089 file URIs returned by PosixUPath/WindowsUPath.as_uri() and fsspec file:// urlpaths used by FilePath, and stop recommending UPath(p.as_uri()) to switch to FilePath.