Repository navigation
upath.core: fix rename() of directories - #575
Merged
Merged
Conversation
UPath.rename() called fs.mv() without recursive=True unless the deprecated keyword argument was passed, so renaming a directory raised on memory:// and silently moved nothing on s3:// while returning the target path. Directory sources are now moved recursively. With fsspec>=2026.6.0 AbstractFileSystem.mv(recursive=True) fails on object stores because copying the pseudo-directory key raises, so the s3 test is marked xfail for those versions.
SFTPFileSystem.mv(old, new) does a native rename that already handles directories and raises TypeError on the injected recursive=True. Also mark the azure rename directory test xfail for fsspec>=2026.6.0 for the same pseudo-directory reason as on s3. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPath.rename() called fs.mv() without recursive=True unless the deprecated keyword argument was passed, so renaming a directory raised on memory:// and silently moved nothing on s3:// while returning the target path. Directory sources are now moved recursively.
With fsspec>=2026.6.0 AbstractFileSystem.mv(recursive=True) fails on object stores because copying the pseudo-directory key raises, so the s3 test is marked xfail for those versions.