Repository navigation
Docs: clarify HTTP directory index predicates - #577
Open
Himanshuagrawal4 wants to merge 1 commit into
Open
Himanshuagrawal4 wants to merge 1 commit into
Himanshuagrawal4 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An HTTP directory index can be a readable HTML document and a directory listing. The usage guide now notes that
is_file()andis_dir()can both be true for such a URL. This documents the current behavior without changing it.Refs #535.
Type of Change
Testing
The local HTTP fixture returned true for both predicates in UPath and fsspec for the index. Reading it and traversing to a child both worked. The plain text child returned true only for
is_file(). The altered usage guide rendered as Markdown. The full test suite was not run locally.Checklist
AI assistance: Codex helped draft the note and run the local checks.