Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@Jxxunnn is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The plan checks page loads on the changed guide and sibling upload guides. It also checks client errors and snippet copies. An issue escalates when client errors appear on those pages or the sibling guides stop loading. Services: Mention PlanWhat changedRequests to RiskA bad MDX render can hide the upload command on this page. Readers may copy a broken command and leave CodePush frames unsymbolicated. Sibling React Native source map guides share the same page renderer. Intended effectThis change is a documentation edit. Site telemetry cannot show the new upload flags. Mark intended_effect unknown from that gap. Page loads of the CodePush guide only show that the page still reaches readers. A 24 hour zero on that path is within the sparse band. Do not treat that zero as absent. Absent would mean the CodePush path stays at zero for 48 hours while sibling source map pages keep loading.
Regression watchA render fault on this page can also break sibling React Native source map pages. Watch those sibling loads against React Native page volume. Watch client errors on React Native transactions as the symptom class. Watch snippet copies as a share of that same volume. Watch React Native not-found counts.
If error events rise, inspect client errors from code tabs on React Native pages. Not observableSite telemetry cannot show that readers now pass |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
DESCRIBE YOUR PR
The CodePush guide uploads only the source map directory, so the application bundle is not uploaded. This PR uploads the bundle and its matching source map together with
--bundleand--bundle-sourcemap, so the Debug ID lookup can resolve both. Source maps stay outside the update directory, which keeps the fix from #15141 (getsentry/sentry-react-native#5148).Why the bundle is needed:
--bundlewith a Hermes bundle (trycmd).Why a map-only upload can look like it works
Some events are still symbolicated. If a module processed earlier in caller-first order has no Debug ID, for example
app:///InternalBytecode.js, its lookup can trigger the release-based path (lookup.rs#L1045-L1066) and may download an artifact bundle from the native build that contains~/main.jsbundle. If that happens before the CodePush module is first fetched, the CodePush module finds a minified-source entry by path (lookup.rs#L1026-L1029) and still uses the CodePush source map by Debug ID. Whether this happens depends on the event's release and dist, the available artifacts, and the server's indexing state and candidate selection.How to reproduce
Verification
Verified CLI artifact preparation with sentry-cli 3.8.0 against a local stub server, using Hermes bytecode and a source map containing a Debug ID. The upload report lists the bundle and the source map with the same Debug ID, as in the integration test above. End-to-end symbolication with the updated command and JSC were not tested.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
🤖 Generated with Claude Code