Repository navigation
docs(ruby): Correct excluded_exceptions defaults - #20245
sentry-junior[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
The plan checks the published options page text, page-load failures, client errors, and missing-page logs. An issue escalates when those pages fail to load or those errors appear. Services: Mention PlanWhat changedThe Ruby options pages now show the excluded_exceptions default as IGNORE_DEFAULT plus PUMA_IGNORE_DEFAULT. The sample suppresses MyApp::IgnorableError. It no longer lists Rails 404 exceptions. sentry-docs must deploy before this text is live. The common MDX file also builds the Rails, Sidekiq, Rack, Resque, and Delayed Job options pages. RiskA bad MDX compile can drop those static pages. Readers then get a 404. A client render fault can throw on the same URLs. Wrong published text leaves readers with the old default. Intended effectFetch the published HTML. The new default string must be present. Absence is a Default cell that still shows only IGNORE_DEFAULT.
Regression watchWatch the six inherited options URLs as one path. Traffic is low. A drop to zero page loads is the 404 signal. One generic client error in 48h is noise. Two or more errors in 24h is not. Exact URL list for every trace query:
If the failure rate rises, check those MDX logs for Not observable
|
DESCRIBE YOUR PR
The Ruby
excluded_exceptionsdocs listSentry::Configuration::IGNORE_DEFAULTas the default. The real default also includesSentry::Configuration::PUMA_IGNORE_DEFAULT. The example also says it suppresses the Rails 404 exceptionsActionController::RoutingErrorandActiveRecord::RecordNotFound, butsentry-railsalready excludes both by default. Adding them again does nothing.Source evidence (sentry-ruby
7.1.0):sentry-ruby/lib/sentry/configuration.rb:self.excluded_exceptions = IGNORE_DEFAULT + PUMA_IGNORE_DEFAULTsentry-rails/lib/sentry/rails/configuration.rb: appendsSentry::Rails::IGNORE_DEFAULT, which includesActionController::RoutingErrorandActiveRecord::RecordNotFoundsentry-sidekiq/lib/sentry/sidekiq/configuration.rb: appendsSentry::Sidekiq::IGNORE_DEFAULTCorrected wording:
Sentry::Configuration::IGNORE_DEFAULT + Sentry::Configuration::PUMA_IGNORE_DEFAULTsentry-railsandsentry-sidekiqadd.cc @sl0thentr0py @solnic
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
via automation
sched_fe39d4dd0d4e77a4b4463de325041d04· Run IDsched_fe39d4dd0d4e77a4b4463de325041d04:1793088000000.--
View Junior Session [Sentry]