Repository navigation
feat(profiling): add nodejs profiling docs - #5776
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lizokm
approved these changes
Nov 15, 2022
lizokm
left a comment
Contributor
There was a problem hiding this comment.
Hi there! I'm the new docs manager :) I've made a few tweaks, but overall this is looking solid.
Co-authored-by: Liza Mock <lizka920@gmail.com>
Co-authored-by: Liza Mock <lizka920@gmail.com>
Co-authored-by: Liza Mock <lizka920@gmail.com>
Co-authored-by: Liza Mock <lizka920@gmail.com>
Co-authored-by: Liza Mock <lizka920@gmail.com>
Contributor
Author
|
Thanks so much @lizokm - I agree with all suggestions and they are all applied now |
imatwawana
approved these changes
Nov 15, 2022
imatwawana
left a comment
Contributor
There was a problem hiding this comment.
I've made some suggestions to make the text more concise. @lizokm, you may want to review my suggestions and make sure you agree. This is also fine as is though apart from a couple formatting tweaks for style. Apart from those, you can take or leave my suggestions.
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
JonasBa
enabled auto-merge (squash)
November 21, 2022 14:51
lforst
pushed a commit
that referenced
this pull request
Nov 22, 2022
* feat(profiling): add nodejs profiling docs * feat(profiling): add alpha mention * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Liza Mock <lizka920@gmail.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Liza Mock <lizka920@gmail.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Liza Mock <lizka920@gmail.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Liza Mock <lizka920@gmail.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Liza Mock <lizka920@gmail.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * Update src/platforms/node/common/profiling/index.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> Co-authored-by: Liza Mock <lizka920@gmail.com> Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass on adding the docs for profiling to node. Since this is an alpha package for now, should we indicate this somewhere in the docs?
Other than that, feedback very much wanted :D