Repository navigation
Fix/5844 explicit breadcrumb clear - #6439
rocky-bgta wants to merge 8 commits into
Conversation
Refs getsentry#5844 Signed-off-by: Md. Nazmus Salahin Rocky <rocky.bgta@gmail.com>
Refs getsentry#5844 Signed-off-by: Md. Nazmus Salahin Rocky <rocky.bgta@gmail.com>
Refs getsentry#5844 Signed-off-by: Md. Nazmus Salahin Rocky <rocky.bgta@gmail.com>
Refs getsentry#5844 Signed-off-by: Md. Nazmus Salahin Rocky <rocky.bgta@gmail.com>
Refs getsentry#5844 Signed-off-by: Md. Nazmus Salahin Rocky <rocky.bgta@gmail.com>
Refs getsentry#5844 Signed-off-by: Md. Nazmus Salahin Rocky <rocky.bgta@gmail.com>
Refs getsentry#5844 Signed-off-by: Md. Nazmus Salahin Rocky <rocky.bgta@gmail.com>
Refs getsentry#5844 Signed-off-by: Md. Nazmus Salahin Rocky <rocky.bgta@gmail.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5a60510. Configure here.
| void addBreadcrumb(@NotNull Breadcrumb crumb); | ||
|
|
||
| void setBreadcrumbs(@NotNull Collection<Breadcrumb> breadcrumbs); | ||
| void clearBreadcrumbs(); |
There was a problem hiding this comment.
Breaking observer API without deprecation
High Severity
Replacing IScopeObserver.setBreadcrumbs with abstract clearBreadcrumbs is binary-incompatible. Existing implementors can throw AbstractMethodError when breadcrumbs are cleared, and ScopeObserverAdapter subclasses that overrode setBreadcrumbs stop receiving clear notifications. Issue #5844 targeted this for 9.0; the repo is still at 8.62.0.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bugbot
Reviewed by Cursor Bugbot for commit 5a60510. Configure here.


Summary
Fixes #5844
Updated the breadcrumb observer handling to use
clearBreadcrumbs()instead ofsetBreadcrumbs().Changes
Testing