perf(metrics): stop re-rendering unchanged metric panels on URL changes by JoshuaKGoldberg · Pull Request #126977 · getsentry/sentry

JoshuaKGoldberg · 2026-10-08T22:20:12Z

Problem: Expanding or collapsing a metric panel writes to the URL. Every panel re-decoded its query params from the URL, and table rows and cells subscribed to the location for their links. So any expansion/collapse -> causes a URL change -> causes every component in every other panel to re-render.

This PR fixes it with a few things:

Sample rows only read the location in their trace link cell, and Explore field cells keep their cell action menus out of location-driven re-renders.
Embedded sample tables keep their rows memoized even when their query is disabled.
Button tracking also returns a stable function

As part of this I extracted renderTraceCell out into a TraceLinkCell component.

Keeping unchanged panels' query params and mutators stable is split out into #128357.

Together with getsentry/sentry-javascript#25336 I think this should fix much of the perf issues around metrics panel toggles.

Collapsing one of three metric panels (median of 12)	Prod	This PR's preview	Delta
Main-thread busy time	159ms	128ms	−20%
Components re-rendered	9,894	1,839	−81%
React commits	7	4	−43%

Closes LOGS-1035.

Expanding or collapsing a metric writes to the URL, which re-rendered every sample table row in every panel because rows read the location for their trace links. Memoize the rows and pass them a stable, metric-param-stripped location instead. Fixes LOGS-1035

linear-code · 2026-10-08T22:20:18Z

LOGS-1035

…e table

BaseExploreFieldRenderer read the location and route for its links, so every Explore table cell re-rendered its action menu, buttons, and tooltip on any URL change. A child component now reads them for the cell value alone. Refs LOGS-1035

…L changes The button tracking hooks returned a new function on every render, so each navigation changed the tracking context and re-rendered every Button and Link. The starred Explore queries list also rebuilt on any query param change, though it only reads the query id and pathname. Refs LOGS-1035

This reverts commit f412c68. The cells kept re-rendering through the per-panel query params context, so moving the location read into a child had no measurable effect. Refs LOGS-1035

Its links subscribe to the location themselves, so they kept re-rendering and the memo saved almost nothing. Refs LOGS-1035

… changes Every URL change re-decoded every metric query and rebuilt each row's mutators, so every panel's query params context changed and re-rendered its charts, toolbars, and table cells. Decoded queries are now reused for unchanged URL values, and each row gets stable mutators. Refs LOGS-1035

Restores f412c68. Now that unchanged metric panels keep stable query params, the location read was the last thing re-rendering each cell's action menu, buttons, and tooltip. Refs LOGS-1035

…035-reduce-lag-when-expanding-or-collapsing-metrics # Conflicts: # static/app/views/explore/metrics/metricInfoTabs/metricsSamplesTableRow.tsx

JoshuaKGoldberg · 2026-10-13T19:44:25Z

@cursor review

cursor

Stale Bugbot comment from a previous run.

…ut effects The stable row mutators read rows that a layout effect updated, but descendant layout effects run first. A group by cleanup in the same commit as a query change could write stale rows to the URL and revert that change. An insertion effect updates them before any layout effect runs. Refs LOGS-1035

…anels Panels with identical URL values received the same decoded query objects, so an in-place change to one would leak into the other. The cache is now keyed by panel position too. Also adds a regression test for the stale mutator fix. Refs LOGS-1035

Refs LOGS-1035

JoshuaKGoldberg · 2026-10-14T14:12:52Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 55ecb2c. Configure here.}

nsdeschenes

LGTM ... tho i had to read up on useInsertionEffect to refresh my memory.

…test ref The tracker only needs the parameterized route path, which is a string that stays equal across query changes, so it can be a plain useCallback dependency.

Keeping unchanged panels' queries and mutators stable needed a ref synced in an insertion effect. The follow-up does it with updater-based setters instead.

…035-reduce-lag-when-expanding-or-collapsing-metrics # Conflicts: # static/gsApp/overrides/useButtonTracking.spec.tsx

…isabled The default meta object was recreated each render, so embedded tables rebuilt their memoized meta and re-rendered every row.

@nsdeschenes

… changes (#128357) Unchanged metric panels now keep the same query params and mutators when another panel changes, because row mutators hand updater functions to `setQueries` instead of closing over the rendered queries. This is done by: * Switching row mutator updater functions to `setQueries` * Moving the URL-backed provider onto `nuqs` and its nice stable setter * Binding each row's mutators to a stable row id, so a mutator held across another row's removal still edits its own row * Resetting `nuqs`'s global URL update queue between tests in the shared test adapter Rapid edits now coalesce into a single history entry, since `nuqs` batches URL writes. Split out of #126977 so we don't have to use esoteric React hooks. Thanks for prodding me on the docs @nsdeschenes 😄

github-actions · 2026-10-22T16:21:51Z

📊 Type Coverage Diff

Metric	Before	After	Delta
Coverage	95.78%	95.78%	±0%
Typed	141,473	141,521	🟢 +48
Untyped	6,227	6,229	🔴 +2

🔍 2 new type safety issues introduced

Non-null assertions (!) (2 new)

File	Line	Detail
`static/app/views/explore/metrics/multiMetricsQueryParams.tsx`	118	`decodedMetricQueries.keys().next().value!`
`static/app/views/explore/metrics/useMetricQueriesController.tsx`	221	`rowMutators[i]!`

This is informational only and does not block the PR.

…035-reduce-lag-when-expanding-or-collapsing-metrics # Conflicts: # static/app/scrapsProviders/tracking.tsx # static/gsApp/overrides/useButtonTracking.spec.tsx

sentry · 2026-10-26T12:32:14Z

Sentry Snapshot Testing

Name	Added	Removed	Changed	Renamed	Unchanged	Skipped	Status
sentry-frontend `sentry-frontend`	-	-	-	-	-	-	✅ 760 uploaded

Base commit 65ab0d9579234f7b0097bf5903e141193409a5fa did not produce snapshots to compare against. Did its snapshot job fail? Try rebasing this branch on a commit with a successful snapshot job.

⚙️ sentry-frontend Snapshot Settings

JoshuaKGoldberg · 2026-10-26T12:41:25Z

@nsdeschenes I ended up refactoring a bunch to not use weird hooks!

) Fixes the frontend build on master after #126977. That PR moved the value rendering out of `BaseExploreFieldRenderer` and into a new `ExploreFieldValue` component. Meanwhile, a separate change landed that reads a per-query `caseInsensitive` prop. After the two merged, `ExploreFieldValue` still referenced `queryCaseInsensitive`, but that variable only exists in the parent's props. This broke `tsc` and threw `ReferenceError: queryCaseInsensitive is not defined` in Jest across the explore and metrics specs. This PR passes the prop down to `ExploreFieldValue`. When a query sets a value, it still wins over the page-level case-insensitivity setting.  via **Josh Goldberg**.    -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC8V02RHC7%3A1793284533.806639) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC8V02RHC7%3A1793284533.806639/?project=4510944073809921)  Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Josh Ghoulberg <joshua.goldberg@sentry.io>

github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 8, 2026

vercel Bot deployed to Preview October 8, 2026 22:20

View deployment

JoshuaKGoldberg changed the title ~~perf(metrics): Stop re-rendering unchanged sample rows on URL changes~~ perf(metrics): stop re-rendering unchanged sample rows on URL changes Oct 13, 2026

ref(metrics): Read location in a trace link cell instead of the sampl…

d1e0954

…e table

vercel Bot deployed to Preview October 13, 2026 13:28

View deployment

JoshuaKGoldberg added 2 commits October 13, 2026 14:14

vercel Bot deployed to Preview October 13, 2026 18:15

View deployment

JoshuaKGoldberg added 3 commits October 13, 2026 15:11

revert: Keep field cell actions from re-rendering on URL changes

5117c01

This reverts commit f412c68. The cells kept re-rendering through the per-panel query params context, so moving the location read into a child had no measurable effect. Refs LOGS-1035

revert: Drop the memoized starred queries list

261cdfa

Its links subscribe to the location themselves, so they kept re-rendering and the memo saved almost nothing. Refs LOGS-1035

vercel Bot deployed to Preview October 13, 2026 19:16

View deployment

perf(explore): Keep field cell actions from re-rendering on URL changes

b14862b

Restores f412c68. Now that unchanged metric panels keep stable query params, the location read was the last thing re-rendering each cell's action menu, buttons, and tooltip. Refs LOGS-1035

vercel Bot deployed to Preview October 13, 2026 19:21

View deployment

JoshuaKGoldberg changed the title ~~perf(metrics): stop re-rendering unchanged sample rows on URL changes~~ perf(metrics): stop re-rendering unchanged metric panels on URL changes Oct 13, 2026

Merge remote-tracking branch 'origin/master' into joshgoldberg/logs-1…

f8c88bf

…035-reduce-lag-when-expanding-or-collapsing-metrics # Conflicts: # static/app/views/explore/metrics/metricInfoTabs/metricsSamplesTableRow.tsx

vercel Bot deployed to Preview October 13, 2026 19:31

View deployment

lil comment removals

59f5d00

vercel Bot deployed to Preview October 13, 2026 19:48

View deployment

cursor Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread static/app/views/explore/metrics/useMetricQueriesController.tsx Outdated

Comment thread static/app/views/explore/metrics/multiMetricsQueryParams.tsx Outdated

JoshuaKGoldberg added 3 commits October 14, 2026 10:04

ref(metrics): Remove new explanatory comments

55ecb2c

Refs LOGS-1035

vercel Bot deployed to Preview October 14, 2026 14:08

View deployment

cursor Bot reviewed Oct 14, 2026

View reviewed changes

JoshuaKGoldberg marked this pull request as ready for review October 14, 2026 14:20

JoshuaKGoldberg requested review from a team as code owners October 14, 2026 14:20

nsdeschenes approved these changes Oct 19, 2026

View reviewed changes

ref(analytics): Key button tracking on the route path instead of a la…

7bcd07d

…test ref The tracker only needs the parameterized route path, which is a string that stays equal across query changes, so it can be a plain useCallback dependency.

vercel Bot deployed to Preview October 21, 2026 14:58

View deployment

JoshuaKGoldberg mentioned this pull request Oct 21, 2026

perf(metrics): keep unchanged metric panels stable when another panel changes #128357

Merged

JoshuaKGoldberg added 2 commits October 21, 2026 11:33

revert(metrics): Move metric panel stability to a follow-up

9526755

Keeping unchanged panels' queries and mutators stable needed a ref synced in an insertion effect. The follow-up does it with updater-based setters instead.

Merge remote-tracking branch 'origin/master' into joshgoldberg/logs-1…

736a69e

…035-reduce-lag-when-expanding-or-collapsing-metrics # Conflicts: # static/gsApp/overrides/useButtonTracking.spec.tsx

vercel Bot deployed to Preview October 21, 2026 15:58

View deployment

perf(metrics): Keep the samples table meta stable when the query is d…

8b1b033

…isabled The default meta object was recreated each render, so embedded tables rebuilt their memoized meta and re-rendered every row.

vercel Bot deployed to Preview October 21, 2026 17:54

View deployment

JoshuaKGoldberg requested a review from a team as a code owner October 22, 2026 16:18

vercel Bot deployed to Preview October 22, 2026 16:20

View deployment

Merge remote-tracking branch 'origin/master' into joshgoldberg/logs-1…

7deab49

…035-reduce-lag-when-expanding-or-collapsing-metrics # Conflicts: # static/app/scrapsProviders/tracking.tsx # static/gsApp/overrides/useButtonTracking.spec.tsx

vercel Bot deployed to Preview October 26, 2026 12:32

View deployment

JoshuaKGoldberg requested a review from nsdeschenes October 26, 2026 12:41

nsdeschenes approved these changes Oct 29, 2026

View reviewed changes

JoshuaKGoldberg merged commit ef1bb91 into master Oct 29, 2026
84 of 85 checks passed

JoshuaKGoldberg deleted the joshgoldberg/logs-1035-reduce-lag-when-expanding-or-collapsing-metrics branch October 29, 2026 14:31

sentry-junior Bot mentioned this pull request Oct 29, 2026

fix(explore): Pass caseInsensitive through to ExploreFieldValue #129188

Merged

Navigation Menu

Repository navigation

perf(metrics): stop re-rendering unchanged metric panels on URL changes - #126977

perf(metrics): stop re-rendering unchanged metric panels on URL changes#126977
JoshuaKGoldberg merged 19 commits into
masterfrom
joshgoldberg/logs-1035-reduce-lag-when-expanding-or-collapsing-metrics

JoshuaKGoldberg commented Oct 8, 2026 •

edited

Loading

Uh oh!

linear-code Bot commented Oct 8, 2026

Uh oh!

JoshuaKGoldberg commented Oct 13, 2026

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg commented Oct 14, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

nsdeschenes left a comment

Uh oh!

github-actions Bot commented Oct 22, 2026 •

edited

Loading

Uh oh!

sentry Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

JoshuaKGoldberg commented Oct 26, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

JoshuaKGoldberg commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code Bot commented Oct 8, 2026

Uh oh!

JoshuaKGoldberg commented Oct 13, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg commented Oct 14, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

nsdeschenes left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Type Coverage Diff

Uh oh!

sentry Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sentry Snapshot Testing

Uh oh!

JoshuaKGoldberg commented Oct 26, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JoshuaKGoldberg commented Oct 8, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

github-actions Bot commented Oct 22, 2026 •

edited

Loading

sentry Bot commented Oct 26, 2026 •

edited

Loading