Repository navigation
Conversation
github-actions
Bot
changed the base branch from
main
to
ranjiGT/advisory-improvement-10179
October 5, 2026 12:21
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The affected range misses the former Go module path, and valid CVSS v3 metadata is removed.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Refines the GoPay TLS verification advisory with package/version metadata and clearer remediation details.
Changes:
- Adds affected Go module ranges and references.
- Expands the vulnerability description and summary.
- Normalizes the CVSS v4 vector.
| File | Description |
|---|---|
GHSA-8f6w-7m2h-mfwg.json |
Updates GoPay advisory metadata, severity, affected versions, and references. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+18
to
36
| { | ||
| "package": { | ||
| "ecosystem": "Go", | ||
| "name": "github.com/go-pay/gopay" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "type": "ECOSYSTEM", | ||
| "events": [ | ||
| { | ||
| "introduced": "1.5.27" | ||
| }, | ||
| { | ||
| "fixed": "1.5.119" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
Author
There was a problem hiding this comment.
Confirmed against the upstream release tags.
v1.5.41 uses the Go module path:
github.com/iGoogle-ink/gopay
Starting with v1.5.42, the module path changes to:
github.com/go-pay/gopay
The upstream go.mod diff between v1.5.41 and v1.5.42 confirms the rename:
-module github.com/iGoogle-ink/gopay
+module github.com/go-pay/gopay
Comment on lines
12
to
+15
| { | ||
| "type": "CVSS_V4", | ||
| "score": "CVSS:4.0/AV:N/AC:H/AT:P/PR:N/UI:N/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N/E:X/CR:X/IR:X/AR:X/MAV:X/MAC:X/MAT:X/MPR:X/MUI:X/MVC:X/MVI:X/MVA:X/MSC:X/MSI:X/MSA:X/S:X/AU:X/R:X/V:X/RE:X/U:X" | ||
| "score": "CVSS:4.0/AV:N/AC:H/AT:P/PR:N/UI:N/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N" | ||
| } |
Author
There was a problem hiding this comment.
Comment 2 — Retain CVSS v3.1
Confirmed. The original advisory contains the following CVSS v3.1 vector:
`CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:N`
This existing CVSS v3.1 entry should be retained alongside the normalized CVSS v4 vector:
`CVSS:4.0/AV:N/AC:H/AT:P/PR:N/UI:N/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N`
The intent of the change is only to normalize the malformed CVSS v4 vector, not to remove the existing valid CVSS v3.1 severity metadata.
I attempted to apply the suggested change, but GitHub returned `Failed to commit suggested changes`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Adds precise Go package and affected-version metadata based on upstream release history.
The insecure default TLS configuration in
pkg/xhttp/client.go, usingtls.Config{InsecureSkipVerify: true}, was introduced by commit 988e18a0f7e75ce002e96614e8d8a1a354f593f8 before the v1.5.27 release.Verification against upstream tags shows that v1.5.26 does not contain this insecure default in
pkg/xhttp/client.go, while v1.5.27 does. The configuration remains present through v1.5.118.Commit f6df04fd4f64a2ad2c303ba063b6502bfdd259fd, released as v1.5.119, removes
InsecureSkipVerify: truefrom the default client.Therefore the affected range is
>= 1.5.27, < 1.5.119, with1.5.119as the patched version.The malformed CVSS v4 vector present in the existing advisory is also normalized to the equivalent base vector accepted by GitHub's CVSS v4 parser.