Repository navigation
Python: Model bytearray construction and take_bytes - #22746
Merged
Merged
Conversation
We model these as string-like taint preserving steps.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the documented behavior and includes comprehensive focused tests.
Review effort: Balanced
Findings: None
What changed in this PR
Adds taint-preserving models for Python byte-array construction and extraction.
Changes:
- Models taint flow through
bytearray(...)andbytearray.take_bytes. - Adds coverage for bound, unbound, aliased, partial, and consuming calls.
- Documents the analysis improvement.
| File | Description |
|---|---|
TaintTrackingPrivate.qll |
Implements byte-array taint steps. |
test_bytearray.py |
Tests supported flows and known imprecision. |
2026-09-22-python315-take-bytes.md |
Adds the change note. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
geoffw0
approved these changes
Oct 8, 2026
geoffw0
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I encourage you to consider modelling .clear() as that seems like a straightforward improvement.
| buffer = bytearray(b"abc") | ||
| taint(buffer) | ||
| buffer.clear() | ||
| ensure_not_tainted(buffer) # $ SPURIOUS: tainted |
Contributor
There was a problem hiding this comment.
This could be fixed easily with a barrier model, right?
Contributor
Author
There was a problem hiding this comment.
I think you're right. I'll add this as a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We model these as string-like taint preserving steps.