Skip to content

Bump minimum VS Code version to 1.101.0 #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josefs merged 2 commits into from
Oct 22, 2026
Merged

Bump minimum VS Code version to 1.101.0 #4619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
955e5df
Bump minimum VS Code version to 1.101.0
josefs Oct 22, 2026
2e38d79
Add changelog entry for VS Code 1.101.0 requirement
josefs Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/ql-vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- After an extension-managed CodeQL CLI update, the notification now offers to open the CLI release notes instead of the extension log. [#1095](https://github.com/github/vscode-codeql/issues/1095)
- Remove support for CodeQL CLI versions older than 2.24.3. [#4573](https://github.com/github/vscode-codeql/pull/4573)
- Add support to the model editor for saving and loading JSON data extensions. [#4576](https://github.com/github/vscode-codeql/pull/4576)
- Increase the required version of VS Code to 1.101.0. [#4619](https://github.com/github/vscode-codeql/pull/4619)

## 1.17.8 - 17 July 2026

Expand Down
4 changes: 2 additions & 2 deletions extensions/ql-vscode/gulpfile.ts/chromium-version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"chromiumVersion": "122",
"electronVersion": "29.4.0"
"chromiumVersion": "134",
"electronVersion": "35.5.1"
}
10 changes: 5 additions & 5 deletions extensions/ql-vscode/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions extensions/ql-vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"url": "https://github.com/github/vscode-codeql"
},
"engines": {
"vscode": "^1.90.0",
"vscode": "^1.101.0",
Comment thread
josefs marked this conversation as resolved.
"node": "^22.21.1",
"npm": ">=8.3.0"
},
Expand Down Expand Up @@ -2137,7 +2137,7 @@
"@types/semver": "^7.7.1",
"@types/tar-stream": "^3.1.4",
"@types/tmp": "^0.2.6",
"@types/vscode": "1.90.0",
"@types/vscode": "1.101.0",
"@types/yauzl": "^3.4.0",
"@typescript-eslint/parser": "^8.71.0",
"@vscode/test-electron": "^3.1.0",
Expand Down
6 changes: 3 additions & 3 deletions extensions/ql-vscode/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,12 +315,12 @@ const shouldUpdateOnNextActivationKey = "shouldUpdateOnNextActivation";

const codeQlVersionRange = DEFAULT_DISTRIBUTION_VERSION_RANGE;

// This is the minimum version of vscode that we _want_ to support. We want to update to Node 20, but that
// requires 1.90 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will
// This is the minimum version of vscode that we _want_ to support. We want to update to Node 22, but that
// requires 1.101 or later. If we change the minimum version in the package.json, then anyone on an older version of vscode will
// silently be unable to upgrade. So, the solution is to first bump the minimum version here and release. Then
// bump the version in the package.json and release again. This way, anyone on an older version of vscode will get a warning
// before silently being refused to upgrade.
const MIN_VERSION = "1.90.0";
const MIN_VERSION = "1.101.0";

function sendConfigTelemetryData() {
const config: Record<string, string> = {};
Expand Down
Loading