Repository navigation
refactor(sonar): use optional chaining for nullable lookups (javascript:S6582) - #33
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sonar rule
javascript:S6582asks for optional chaining instead of&&guards when reading a nested property from a possibly-null value. Two guards inmain.jsused that older pattern.Changes
gitify/contents/code/main.js:window.output && window.output.geometry→window.output?.geometry.gitify/contents/code/main.js:lastAnchor && lastAnchor.pointer→lastAnchor?.pointer.Both expressions keep the same semantics:
undefined/nullstill short-circuits toundefined(falsy), so the existing branches are unchanged.Verification
pnpm lint:check— passedpnpm test— 28 passed, 0 failedSonar issues
https://sonarcloud.io/project/issues?id=gitify-app_kde&s=IMPACT_RANK&issueStatuses=OPEN&rules=javascript%3AS6582