Repository navigation
TraceServiceSettings.Builder not very idiomatic #2610
Description
I'm having to do this weird cast, which should be avoidable:
TraceServiceClient.create(
((TraceServiceSettings.Builder) TraceServiceSettings.newBuilder()
.setCredentialsProvider(
StackdriverTraceAutoConfiguration.this.finalCredentialsProvider)
.setExecutorProvider(executorProvider))
.build())
Notice the (TraceServiceSettings.Builder) cast, because setExecutorProvider() is inherited from the abstract ClientSettings and should probably be overwritten to return a TraceServiceSettings.Builder.
Activity
garrettjonesgoogle commentedon Nov 10, 2017
What version of Java are you using?
joaoandremartins commentedon Nov 10, 2017
Was using jdk1.8.0_121, though seeing the same thing with jdk1.8.0_151.
garrettjonesgoogle commentedon Nov 10, 2017
Also what version of gax are you using?
joaoandremartins commentedon Nov 13, 2017
Apologies, user error.
gaxversion was being set to 1.8.1 where it shouldn't.feat: Add ChannelPoolSettings Getter for gRPC's ChannelProvider (#2612)
chore: remove OwlBot required status check from sync-repo-settings.ya…
deps: update dependency com.google.cloud:google-cloud-storage to v2.6…
deps: update dependency com.google.cloud:google-cloud-storage to v2.6…
fix: populate table id for materialized view (googleapis#2610)